Skip to content

Use robustness traffic generation #19852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

nwnt
Copy link

@nwnt nwnt commented May 2, 2025

Fix #19839

This currently includes exporting etcdTraffic so it can be reused by the antithesis robustness tests.

@k8s-ci-robot
Copy link

Hi @nwnt. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Member

serathius commented May 4, 2025

Looks good, nice work.

Left couple of comments just nits.

@nwnt nwnt force-pushed the nwnt/use-robustness-traffic-gen branch from 1f3be25 to 3c5c7c7 Compare May 5, 2025 01:31
@nwnt
Copy link
Author

nwnt commented May 5, 2025

@serathius thank you for the review comments, they should have all been fixed. it's ready for another review :)

@serathius serathius force-pushed the nwnt/use-robustness-traffic-gen branch 3 times, most recently from 6d0d346 to f35bfa0 Compare May 5, 2025 08:35
@serathius serathius force-pushed the nwnt/use-robustness-traffic-gen branch from f35bfa0 to 1585023 Compare May 5, 2025 08:35
@serathius
Copy link
Member

/ok-to-test

@serathius
Copy link
Member

Applied some small patches to minimize back and forth due to timezones. Some changes:

  • baseTime also needs to be reused between clients
  • we should avoid global variables other than configuration
  • we shouldn't use generic functions if not needed. wrap is an overkill for one case where we need to wait some time and close channel.
  • Making all fields in traffic was too much, we just need a separate traffic shape.

Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius serathius force-pushed the nwnt/use-robustness-traffic-gen branch from d04cea6 to 3860239 Compare May 5, 2025 08:58
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.82%. Comparing base (eae9a91) to head (3860239).
Report is 3 commits behind head on main.

Additional details and impacted files

see 159 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19852      +/-   ##
==========================================
- Coverage   68.64%   61.82%   -6.83%     
==========================================
  Files         424      409      -15     
  Lines       35862    34637    -1225     
==========================================
- Hits        24619    21413    -3206     
- Misses       9808    11647    +1839     
- Partials     1435     1577     +142     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae9a91...3860239. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 158b9e0 into etcd-io:main May 5, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Antithesis] Use robustness traffic generation
3 participants