-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Use robustness traffic generation #19852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @nwnt. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tests/antithesis/test-template/go-delete-keys/serial_driver_delete_keys.go
Outdated
Show resolved
Hide resolved
tests/antithesis/test-template/go-delete-keys/serial_driver_delete_keys.go
Outdated
Show resolved
Hide resolved
tests/antithesis/test-template/go-delete-keys/serial_driver_delete_keys.go
Outdated
Show resolved
Hide resolved
Looks good, nice work. Left couple of comments just nits. |
1f3be25
to
3c5c7c7
Compare
@serathius thank you for the review comments, they should have all been fixed. it's ready for another review :) |
6d0d346
to
f35bfa0
Compare
Signed-off-by: Nont <[email protected]>
f35bfa0
to
1585023
Compare
/ok-to-test |
Applied some small patches to minimize back and forth due to timezones. Some changes:
|
Signed-off-by: Marek Siarkowicz <[email protected]>
d04cea6
to
3860239
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 159 files with indirect coverage changes @@ Coverage Diff @@
## main #19852 +/- ##
==========================================
- Coverage 68.64% 61.82% -6.83%
==========================================
Files 424 409 -15
Lines 35862 34637 -1225
==========================================
- Hits 24619 21413 -3206
- Misses 9808 11647 +1839
- Partials 1435 1577 +142 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #19839
This currently includes exporting etcdTraffic so it can be reused by the antithesis robustness tests.