Skip to content

[Antithesis] Validate history collected by recording client #19868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abdurrehman107
Copy link
Member

This PR addresses #19840 and is supposed to run validation on the history collected by the recording client.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdurrehman107
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abdurrehman107
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link

@abdurrehman107: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify b22e73c link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.41%. Comparing base (b2f243c) to head (b22e73c).
Report is 15 commits behind head on main.

Current head b22e73c differs from pull request most recent head 91a43a7

Please upload reports for the commit 91a43a7 to get more accurate results.

Additional details and impacted files

see 162 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19868      +/-   ##
==========================================
- Coverage   68.83%   61.41%   -7.42%     
==========================================
  Files         424      407      -17     
  Lines       35862    34510    -1352     
==========================================
- Hits        24685    21195    -3490     
- Misses       9747    11714    +1967     
- Partials     1430     1601     +171     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f243c...91a43a7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-pr-6 branch from a351617 to 91a43a7 Compare May 7, 2025 10:17
@abdurrehman107 abdurrehman107 requested a review from serathius May 7, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants