Skip to content

Use static list of keys in model #19973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

@serathius serathius commented May 18, 2025

                                                      │  old.bench   │             new2.bench              │
                                                      │    sec/op    │   sec/op     vs base                │
ValidateLinearizableOperations/Successes-12             1128.6µ ± 1%   874.9µ ± 2%  -22.48% (p=0.000 n=10)
ValidateLinearizableOperations/AllFailures-12            355.5µ ± 1%   171.6µ ± 3%  -51.73% (p=0.000 n=10)
ValidateLinearizableOperations/PutFailuresWithRead-12    242.5µ ± 1%   194.9µ ± 5%  -19.64% (p=0.000 n=10)
geomean                                                  459.9µ        308.1µ       -33.01%

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius serathius force-pushed the robustness-static branch from 09d1779 to 375808c Compare May 18, 2025 16:08
@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci-etcd-robustness-release34-amd64 375808c link true /test ci-etcd-robustness-release34-amd64
ci-etcd-robustness-release36-amd64 375808c link true /test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants