[Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2) #21071

henrybear327 · 2026-01-02T12:47:46Z

Implement RunWatchLoop in etcd traffic.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

serathius · 2026-01-02T13:21:59Z

/retest

tests/robustness/traffic/kubernetes.go

tests/robustness/traffic/traffic.go

codecov · 2026-01-02T13:53:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.57%. Comparing base (a438759) to head (986527e).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21071      +/-   ##
==========================================
+ Coverage   68.44%   68.57%   +0.12%     
==========================================
  Files         429      429              
  Lines       35281    35281              
==========================================
+ Hits        24149    24194      +45     
+ Misses       9732     9691      -41     
+ Partials     1400     1396       -4

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a438759...986527e. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tests/robustness/traffic/traffic.go

tests/antithesis/test-template/robustness/traffic/main.go

tests/robustness/traffic/traffic.go

serathius · 2026-01-05T09:55:01Z

Have you verified how this PR changes reproducibility of previous issues found by robustness?

serathius · 2026-01-05T10:16:11Z

I think this PR is the best next step as it migrates openWatchPeriodically logic to the new RunWatchLoop.

Left couple of comments, also I'm testing it for reproduction of old watch issues.

henrybear327 · 2026-01-06T07:43:00Z

Have you verified how this PR changes reproducibility of previous issues found by robustness?

This is in progress.

henrybear327 · 2026-01-06T07:43:36Z

I think this PR is the best next step as it migrates openWatchPeriodically logic to the new RunWatchLoop.

Left couple of comments, also I'm testing it for reproduction of old watch issues.

Thank you for helping with the testing. I have closed the old part 2 PR and focus on this one instead.

serathius · 2026-01-06T14:17:18Z

Please squash commits

tests/robustness/traffic/traffic.go

k8s-ci-robot · 2026-01-06T14:20:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrybear327, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…or etcd traffic Signed-off-by: Marek Siarkowicz <[email protected]> Signed-off-by: Chun-Hung Tseng <[email protected]>

k8s-ci-robot · 2026-01-07T02:46:56Z

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-coverage-report	`986527e`	link	true	`/test pull-etcd-coverage-report`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

serathius · 2026-01-07T09:19:49Z

tests/antithesis/test-template/robustness/traffic/main.go

 		MaxNonUniqueRequestConcurrency: 3,
-		BackgroundWatchConfig: options.BackgroundWatchConfig{
+		WatchConfig: options.WatchConfig{
 			Interval:       0,


So you are enabling the mechanism in robustness tests but not in Antithesis? Why?

Also interval = 0, means create watch continiously.

serathius · 2026-01-07T09:20:45Z

tests/robustness/traffic/traffic.go

+			return
+		case <-p.Finish:
+			return
+		case <-time.After(p.Interval):


What happens if interval is set to 0 ?

henrybear327 requested a review from serathius January 2, 2026 12:47

henrybear327 self-assigned this Jan 2, 2026

k8s-ci-robot added area/robustness-testing area/testing size/L labels Jan 2, 2026

henrybear327 marked this pull request as draft January 2, 2026 13:01

k8s-ci-robot added the do-not-merge/work-in-progress label Jan 2, 2026

serathius reviewed Jan 2, 2026

View reviewed changes

tests/robustness/traffic/kubernetes.go Outdated Show resolved Hide resolved

serathius reviewed Jan 2, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Show resolved Hide resolved

serathius reviewed Jan 2, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Outdated Show resolved Hide resolved

serathius reviewed Jan 2, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Outdated Show resolved Hide resolved

serathius reviewed Jan 2, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Show resolved Hide resolved

henrybear327 force-pushed the robustness/watch-refactor-pr2 branch from cc5fa24 to 2e688e4 Compare January 3, 2026 06:12

henrybear327 marked this pull request as ready for review January 3, 2026 06:24

k8s-ci-robot removed the do-not-merge/work-in-progress label Jan 3, 2026

henrybear327 force-pushed the robustness/watch-refactor-pr2 branch from 2e688e4 to 23abb59 Compare January 3, 2026 06:30

henrybear327 changed the title ~~robustness: implement RunWatchLoop and integrate into robustness test~~ [Robustness test] Implement RunWatchLoop and integrate into robustness test Jan 3, 2026

henrybear327 changed the title ~~[Robustness test] Implement RunWatchLoop and integrate into robustness test~~ [Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2) Jan 3, 2026

henrybear327 force-pushed the robustness/watch-refactor-pr2 branch 3 times, most recently from 906157f to f4baca0 Compare January 3, 2026 17:09

serathius reviewed Jan 3, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Show resolved Hide resolved

henrybear327 force-pushed the robustness/watch-refactor-pr2 branch 2 times, most recently from c8d1332 to 97dc9ba Compare January 4, 2026 07:25

henrybear327 changed the title ~~[Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2)~~ [Robustness test] Implement RunWatchLoop and integrate into robustness test (part 3) Jan 4, 2026

henrybear327 requested a review from serathius January 4, 2026 07:30

serathius reviewed Jan 5, 2026

View reviewed changes

tests/antithesis/test-template/robustness/traffic/main.go Show resolved Hide resolved

serathius reviewed Jan 5, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Outdated Show resolved Hide resolved

henrybear327 changed the title ~~[Robustness test] Implement RunWatchLoop and integrate into robustness test (part 3)~~ [Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2) Jan 6, 2026

serathius reviewed Jan 6, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Outdated Show resolved Hide resolved

serathius reviewed Jan 6, 2026

View reviewed changes

tests/robustness/traffic/traffic.go Outdated Show resolved Hide resolved

serathius approved these changes Jan 6, 2026

View reviewed changes

k8s-ci-robot added the approved label Jan 6, 2026

robustness: remove openWatchPeriodically and implement RunWatchLoop f…

986527e

…or etcd traffic Signed-off-by: Marek Siarkowicz <[email protected]> Signed-off-by: Chun-Hung Tseng <[email protected]>

henrybear327 force-pushed the robustness/watch-refactor-pr2 branch from 388c287 to 986527e Compare January 7, 2026 02:13

serathius reviewed Jan 7, 2026

View reviewed changes

[Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2) #21071

Are you sure you want to change the base?

[Robustness test] Implement RunWatchLoop and integrate into robustness test (part 2) #21071

Conversation

henrybear327 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serathius commented Jan 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serathius commented Jan 5, 2026

Uh oh!

serathius commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrybear327 commented Jan 6, 2026

Uh oh!

henrybear327 commented Jan 6, 2026

Uh oh!

serathius commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 6, 2026

Uh oh!

k8s-ci-robot commented Jan 7, 2026

Uh oh!

serathius Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

serathius Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

serathius Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

henrybear327 commented Jan 2, 2026 •

edited

Loading

codecov bot commented Jan 2, 2026 •

edited

Loading

serathius commented Jan 5, 2026 •

edited

Loading