Skip to content

Conversation

@henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Jan 3, 2026

Implement RunWatchLoop in Kubernetes traffic.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@henrybear327 henrybear327 requested a review from serathius January 3, 2026 06:35
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327 henrybear327 self-assigned this Jan 3, 2026
@henrybear327 henrybear327 changed the title robustness: implement RunWatchLoop for kubernetes traffic [Robustness test] Implement RunWatchLoop for kubernetes traffic Jan 3, 2026
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.50%. Comparing base (a438759) to head (14a04c4).
⚠️ Report is 9 commits behind head on main.

⚠️ Current head 14a04c4 differs from pull request most recent head dd8fd43

Please upload reports for the commit dd8fd43 to get more accurate results.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21076      +/-   ##
==========================================
+ Coverage   68.44%   68.50%   +0.05%     
==========================================
  Files         429      429              
  Lines       35281    35281              
==========================================
+ Hits        24149    24168      +19     
+ Misses       9732     9712      -20     
- Partials     1400     1401       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a438759...dd8fd43. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrybear327 henrybear327 changed the title [Robustness test] Implement RunWatchLoop for kubernetes traffic [Robustness test] Implement RunWatchLoop for kubernetes traffic (part 3) Jan 3, 2026
@henrybear327 henrybear327 force-pushed the robustness/watch-refactor-pr2-kubernetes branch 7 times, most recently from 323812d to 39f0369 Compare January 4, 2026 07:25
@henrybear327 henrybear327 changed the title [Robustness test] Implement RunWatchLoop for kubernetes traffic (part 3) [Robustness test] Implement RunWatchLoop for kubernetes traffic (part 4) Jan 4, 2026
@henrybear327 henrybear327 force-pushed the robustness/watch-refactor-pr2-kubernetes branch from 39f0369 to 14a04c4 Compare January 6, 2026 07:33
@henrybear327 henrybear327 changed the title [Robustness test] Implement RunWatchLoop for kubernetes traffic (part 4) [Robustness test] Implement RunWatchLoop for kubernetes traffic (part 3) Jan 6, 2026
…or etcd traffic

Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 force-pushed the robustness/watch-refactor-pr2-kubernetes branch from 14a04c4 to dd8fd43 Compare January 7, 2026 02:13
@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 7, 2026

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 dd8fd43 link true /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants