Skip to content

etcdctl: fix slice bounds trimming single-quoted args #21307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huajianxiaowanzi wants to merge 3 commits into
base: main
Choose a base branch
from
+79 −1
Open

etcdctl: fix slice bounds trimming single-quoted args #21307

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5598893
etcdctl: fix slice bounds trimming single-quoted args
huajianxiaowanzi Feb 13, 2026
7a16339
etcdctl: add unit test for Argify
huajianxiaowanzi Feb 13, 2026
d1d507e
etcdctl: add license header
huajianxiaowanzi Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etcdctl/ctlv3/command/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func Argify(s string) []string {
}
if args[i][0] == '\'' {
// 'single-quoted string'
args[i] = args[i][1 : len(args)-1]
args[i] = args[i][1 : len(args[i])-1]
Copy link
Member

@ahrtr ahrtr Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Can you please add an unit test?

Copy link
Contributor Author

@huajianxiaowanzi huajianxiaowanzi Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test have been added.

Could you please take a look?

} else if args[i][0] == '"' {
// "double quoted string"
if _, err := fmt.Sscanf(args[i], "%q", &args[i]); err != nil {
Expand Down