tests: migrate ctl_v3_kv_test.go to common testing framework#21333
tests: migrate ctl_v3_kv_test.go to common testing framework#21333veeceey wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: veeceey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @veeceey. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Migrate PutIgnoreValue, PutIgnoreLease, Get (with rev, keys-only, count-only, min/max create/mod rev), and Delete tests from tests/e2e/ctl_v3_kv_test.go to the common testing framework in tests/common/kv_test.go, enabling them to run in both e2e and integration modes. Add IgnoreValue and IgnoreLease fields to config.PutOptions and implement support in both e2e (etcdctl) and integration client backends. Retain e2e-specific tests (GetFormat, GetRevokedCRL, PutClientTLSFlagByEnv) that depend on etcdctl output format or TLS-specific behavior. Fixes etcd-io#20550 Signed-off-by: Varun Chawla <varun_6april@hotmail.com>
8463187 to
1ceb0c2
Compare
|
/ok-to-test |
|
@veeceey: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #21333 +/- ##
==========================================
- Coverage 68.48% 68.41% -0.08%
==========================================
Files 428 428
Lines 35262 35277 +15
==========================================
- Hits 24149 24133 -16
- Misses 9724 9751 +27
- Partials 1389 1393 +4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary
PutIgnoreValue,PutIgnoreLease,Get(with rev, keys-only, count-only, min/max create/mod rev), andDeletetests fromtests/e2e/ctl_v3_kv_test.goto the common testing framework intests/common/kv_test.goIgnoreValueandIgnoreLeasefields toconfig.PutOptionsand implement support in both e2e (etcdctl) and integration client backendsGetFormat,GetRevokedCRL,PutClientTLSFlagByEnv) that depend on etcdctl output format or TLS-specific behaviorTest plan
TestKVPutIgnoreValuepasses with bothe2eandintegrationbuild tagsTestKVPutIgnoreLeasepasses with bothe2eandintegrationbuild tagsTestCtlV3GetFormat,TestCtlV3GetRevokedCRL,TestCtlV3PutClientTLSFlagByEnv) still passTestKVPut,TestKVGet,TestKVDelete) are unaffectedFixes #20550
🤖 Generated with Claude Code