Skip to content

Comments

tests: migrate ctl_v3_kv_test.go to common testing framework#21333

Open
veeceey wants to merge 1 commit intoetcd-io:mainfrom
veeceey:fix/issue-20550-migrate-kv-test
Open

tests: migrate ctl_v3_kv_test.go to common testing framework#21333
veeceey wants to merge 1 commit intoetcd-io:mainfrom
veeceey:fix/issue-20550-migrate-kv-test

Conversation

@veeceey
Copy link

@veeceey veeceey commented Feb 20, 2026

Summary

  • Migrate PutIgnoreValue, PutIgnoreLease, Get (with rev, keys-only, count-only, min/max create/mod rev), and Delete tests from tests/e2e/ctl_v3_kv_test.go to the common testing framework in tests/common/kv_test.go
  • Add IgnoreValue and IgnoreLease fields to config.PutOptions and implement support in both e2e (etcdctl) and integration client backends
  • Retain e2e-specific tests (GetFormat, GetRevokedCRL, PutClientTLSFlagByEnv) that depend on etcdctl output format or TLS-specific behavior

Test plan

  • Verify TestKVPutIgnoreValue passes with both e2e and integration build tags
  • Verify TestKVPutIgnoreLease passes with both e2e and integration build tags
  • Verify remaining e2e-specific tests (TestCtlV3GetFormat, TestCtlV3GetRevokedCRL, TestCtlV3PutClientTLSFlagByEnv) still pass
  • Verify existing common tests (TestKVPut, TestKVGet, TestKVDelete) are unaffected

Fixes #20550

🤖 Generated with Claude Code

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: veeceey
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @veeceey. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Migrate PutIgnoreValue, PutIgnoreLease, Get (with rev, keys-only,
count-only, min/max create/mod rev), and Delete tests from
tests/e2e/ctl_v3_kv_test.go to the common testing framework in
tests/common/kv_test.go, enabling them to run in both e2e and
integration modes.

Add IgnoreValue and IgnoreLease fields to config.PutOptions and
implement support in both e2e (etcdctl) and integration client
backends.

Retain e2e-specific tests (GetFormat, GetRevokedCRL,
PutClientTLSFlagByEnv) that depend on etcdctl output format or
TLS-specific behavior.

Fixes etcd-io#20550

Signed-off-by: Varun Chawla <varun_6april@hotmail.com>
@veeceey veeceey force-pushed the fix/issue-20550-migrate-kv-test branch from 8463187 to 1ceb0c2 Compare February 23, 2026 01:59
@serathius
Copy link
Member

/ok-to-test

@k8s-ci-robot
Copy link

@veeceey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 1ceb0c2 link true /test pull-etcd-verify
pull-etcd-integration-1-cpu-arm64 1ceb0c2 link true /test pull-etcd-integration-1-cpu-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.41%. Comparing base (11e4bce) to head (1ceb0c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21333      +/-   ##
==========================================
- Coverage   68.48%   68.41%   -0.08%     
==========================================
  Files         428      428              
  Lines       35262    35277      +15     
==========================================
- Hits        24149    24133      -16     
- Misses       9724     9751      +27     
- Partials     1389     1393       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e4bce...1ceb0c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Migrate tests/e2e/ctl_v3_kv_test.go to common testing framework

3 participants