Skip to content

fix: ensure consistent Docker image manifest format across releases#22172

Open
kairosci wants to merge 1 commit into
etcd-io:mainfrom
kairosci:fix/21007-docker-image-manifest-consistency
Open

fix: ensure consistent Docker image manifest format across releases#22172
kairosci wants to merge 1 commit into
etcd-io:mainfrom
kairosci:fix/21007-docker-image-manifest-consistency

Conversation

@kairosci

@kairosci kairosci commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Move Docker image builds from local release scripts to a GitHub Actions workflow so every release uses the same Docker/buildx version, eliminating the mediaType inconsistency across different release persons' machines. The workflow triggers on release published, downloads release binaries, builds multi-arch images with buildx (--sbom=false --provenance=false), verifies the manifest is a multi-platform list/index, and tests the images before pushing to gcr.io and quay.io.

Fixes #21007

@kubernetes-prow

Copy link
Copy Markdown

Hi @kairosci. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kairosci
kairosci force-pushed the fix/21007-docker-image-manifest-consistency branch from 814a476 to d900152 Compare July 23, 2026 10:24
@kubernetes-prow kubernetes-prow Bot added github_actions Pull requests that update GitHub Actions code size/L and removed size/S labels Jul 23, 2026
@kairosci

Copy link
Copy Markdown
Contributor Author

/assign @ahrtr

@kairosci
kairosci force-pushed the fix/21007-docker-image-manifest-consistency branch from d900152 to f58b0c6 Compare July 23, 2026 11:20
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kairosci
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…releases

Disable SBOM and provenance in buildx, add manifest type verification,
and add GitHub Actions workflow to build images deterministically in CI
instead of locally on release persons' machines.

Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
@kairosci
kairosci force-pushed the fix/21007-docker-image-manifest-consistency branch from f58b0c6 to 30f3470 Compare July 23, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code needs-ok-to-test size/L

Development

Successfully merging this pull request may close these issues.

Improve release process to ensure we have stable & consistent format (mediaType)

2 participants