master..merge/foundation release/1.10.23 tests generate fixes statefix difficulty test v2 #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eth/catalyst: return syncing not accepted * eth/catalyst: fix test
* eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
…(#25405) Signed-off-by: Delweng <[email protected]>
complier/solidity:add json.Unmarshal err check
* cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges
eth: fix typo
build: upgrade -dlgo version to Go 1.18.5
…5381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating.
This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments.
This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size.
…eAccessList (#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate.
This creates some infrastructure to share resources between graphql API objects.
Signed-off-by: Delweng <[email protected]>
* all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test
…5458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <[email protected]> Co-authored-by: rjl493456442 <[email protected]>
* cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue
Co-authored-by: Felix Lange <[email protected]>
This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See #25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about.
* all: polish tests * core: apply feedback from Guillaume * core: fix comment
signer/rules: register clef api properly when rules are used, fixes #25298
This code was used in earlier version of the test generation logic, which extended some given xclient suite with ETC support by writing the results of a test to a new file. Difficulty tests at the time used NDJSON as an additional encoding, but this is no longer. Now, core-geth uses xclient tests generated by retesteth (which uses core-geth as a filler client; actually the t8ntool command provided by the repo). Resolves - #510 (comment) - #510 (comment) Date: 2022-12-20 06:28:24-08:00 Signed-off-by: meows <[email protected]>
Usually devs forget to update Marshalers that has been generated by “go generate”, this Action will just check if a diff exists and let the developers know on a PR basis
…/types/genesisT: run 'go generate ./...' with partial success
A few things I learned along the way this evening.
- solc in path must be 0.6.0 or some mysterious upper
bound less than the latest available versions that I
also tried.
- solcjs is not solc. npm install solc installs solcjs
which is like solc but is not solc.
All of this partially fixes an error which looked like this.
go generate ./...
protoc-gen-go: no such flag -import_path
--go_out: protoc-gen-go: Plugin failed with status code 1.
accounts/usbwallet/trezor/trezor.go:45: running 'protoc': exit status 1
Error: Source file requires different compiler version (current compiler is 0.8.5+commit.a4f2e591.Linux.g++) - note that nightly builds are considered to be strictly less than the released version
--> contract/oracle.sol:1:1:
|
1 | pragma solidity ^0.6.0;
| ^^^^^^^^^^^^^^^^^^^^^^^
contracts/checkpointoracle/oracle.go:20: running 'solc': exit status 1
The error now looks like this
go generate ./...
protoc-gen-go: no such flag -import_path
--go_out: protoc-gen-go: Plugin failed with status code 1.
Maybe we don't even want these changes. I don't know.
I just want the command to work for the sake of order
in the universe.
But seriously
- maybe we should upgrade the Solidity version pragma too/instead?
- maybe proto-gen-go actually wants a different version than 'latest',
(which is what 'make devtools' installs).
- maybe we report the issue at ethereum. their trezor.go looks same
same.
Goodnight, to dream of green lights.
Date: 2022-12-20 19:40:04-08:00
Signed-off-by: meows <[email protected]>
…dd config type switch) Date: 2023-01-10 08:11:37-08:00 Signed-off-by: meows <[email protected]>
… 1s sleep They depend on the output of a geth instance. Geth can take a while to start up, and assertions about geth logs should normally use some kind of a hook to decide when its ok to check the logs (eg startup complete). Date: 2023-01-10 09:48:43-08:00 Signed-off-by: meows <[email protected]>
Revering the EVMCv10 upgrade. I can't get all tests to pass with EVM One. Date: 2023-01-10 10:36:57-08:00 Signed-off-by: meows <[email protected]>
Date: 2023-01-10 10:38:13-08:00 Signed-off-by: meows <[email protected]>
Date: 2023-01-10 10:40:11-08:00 Signed-off-by: meows <[email protected]>
These tests keep failing... sometimes. This is a shot in the dark. Date: 2023-01-10 11:54:56-08:00 Signed-off-by: meows <[email protected]>
… in go-generate-check We currently have a modified generated file which will cause this check to always file, until we actually fix the generated code, we decided to whitelist this file. The file is: `params/types/genesisT/gen_genesis.go`
- skip protobuf installation as trezor code generation requires special handling - whitelist `params/types/genesisT/gen_genesis.go` which is custom modified
… a failure in go-generate-check
…heck for making checkpointoracle
I think this helps with readability. Date: 2023-01-11 09:03:55-08:00 Signed-off-by: meows <[email protected]>
…om:etclabscore/core-geth into merge/foundation-release/1.10.26
…-generate-check.yml
…0.26-isaac-no-evmc Merge/foundation release/1.10.26 <- Remove EVMCv10 upgrade, minor fixes
…flows: go-generate-check changed logic for whitelisting changes in generated files directly The intention of this commit is to not break/change the logic for developers when coding. This script serves as a warning notification if a developer forgets to generate those files using gencodec. On specific cases where generated files are modified, we revert the modifications and compare the files so as they will show up any changes in the original files. The developer then will find out the correct way to resolve generating the new files and keeping the modifications intact if needed.
…0.26 Merge/foundation release/1.10.26
Master: b909e85 These scripts were modified in the merge (92d5b25) and had upgraded to versions that use EVMCv10. This patch does (or should) not upgrade EVMC (from v7 to v10). So this is stepping these deps back to their v7-support targets. Date: 2023-01-19 13:26:26-08:00 Signed-off-by: meows <[email protected]>
|
I agree @meowsbits. Let's merge this one and close #500. |
ziogaschr
approved these changes
Jan 20, 2023
meowsbits
deleted the
merge/foundation-release/1.10.23-tests-generate-fixes-statefix-difficulty-test-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch just merged #510. It is now a candidate for merge to
master.Alternatively, we could change the base to
merge/foundation-release/1.10.23(#500), and then merge that one. Thoughts on that @ziogaschr? For me, I lean toward pull this direct to master and close #500; I expect this branch has everythingand more frommerge/foundation-release/1.10.23, and we've more lately been working and testing with this branch.