Fix issues when installing ete4 on Windows.#783
Conversation
|
Yes, it is a great progress, any managers could handle this ? |
|
@jordibc @ArnaudBelcour @idoerg @fransua Can you hearing me ? There enhancement is very important. |
|
I also give PR for this issue, the solution is equal and modify some annotations and configuration. see #793 |
|
+1 — tested this PR on Windows 11 (Python 3.11, MSVC Build Tools). Without the patch, With this PR applied (via A note on the related PR #793: it carries the same @jordibc, @fransua — would really appreciate a review. There's currently no working
Sincerely, Chang Wan Seo |
Hi,
I am using GitHub Actions to test tools on Windows. Since I have modified these tools to use ete4, there is an issue with the Windows build when it tries to install ete4 using pip (error encountered with ete4 4.1.1 and 4.3.0). It happens during the compilation by Cython of ete4. But it is not happening with Ubuntu or macOS builds.
You can find a full traceback of this error here.
After several tests, I found that the error comes from the separator used in the
setup.pyfile:https://github.com/etetoolkit/ete/blob/ete4/setup.py#L10
Indeed, the
/works for Ubuntu and macOS, but for Windows it is not correct and leads to errors. So I created this PR to fix this and useos.path.sepinstead to specify the path separator and to have the correct one for Windows.Also, I implement the fix proposed in #763, to solve KeyError issue on Windows.
With these two changes, ete4 was installed correctly on Windows, on different runs:
https://github.com/AuReMe/metage2metabo/actions/runs/15068672311
https://github.com/AuReMe/emapper2gbk/actions/runs/15069612333
Best regards,
Arnaud Belcour.