Skip to content

OpenVM check output#160

Merged
jsign merged 4 commits into
masterfrom
han/feature/openvm-check-output
Sep 8, 2025
Merged

OpenVM check output#160
jsign merged 4 commits into
masterfrom
han/feature/openvm-check-output

Conversation

@han0110

@han0110 han0110 commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

Base on #74, need to rebased after it's merged.

This PR:

  • Upgrade ere to 0.0.12-f32de5f that has OpenVM GPU proving support
  • Add output check for OpenVM by using sha256 digest of the public inputs.

@jsign

jsign commented Sep 7, 2025

Copy link
Copy Markdown
Collaborator

@han0110, thanks! :)

Reg #74, was merged so it's good to rebase.
Reg the failing CI, in 0.0.12-a9a0ce3 there's also a bump in Risc0 SDK to v3.0.3, so maybe this failure is related the missing bump in the SDK in the corresponding ere-guests programs.

We could try to add OpenVM SDK in the integration tests at least for the empty_program and empty_block as bare minimum integration tests (if supports the mainnet (as in SP1 and Risc0) one would be ideal but not sure yet how fast it runs in CI). I can do that in a follow up PR too.

@han0110
han0110 force-pushed the han/feature/openvm-check-output branch from 2b8838a to cb498d7 Compare September 8, 2025 05:27
@han0110
han0110 force-pushed the han/feature/openvm-check-output branch from cb498d7 to 9ba3a62 Compare September 8, 2025 05:36
@han0110
han0110 marked this pull request as ready for review September 8, 2025 06:17
Comment on lines -13 to -15
risc0-zkvm-platform = { version = "=2.0.4", default-features = false, features = [
"sys-getenv",
] }

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env::cycle_count is available by default, so removing this.

@jsign jsign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsign
jsign merged commit 65d94b8 into master Sep 8, 2025
26 checks passed
@jsign
jsign deleted the han/feature/openvm-check-output branch September 8, 2025 11:42
WiseMrMusa pushed a commit to NethermindEth/zkevm-benchmark-workload that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants