Skip to content

Paraview recipe #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open

Paraview recipe #39

wants to merge 70 commits into from

Conversation

biddisco
Copy link

@biddisco biddisco commented Aug 23, 2023

This PR builds a minimal paraview using EGL on daint and eiger.

@jfavre
Copy link

jfavre commented Feb 7, 2024

installation on ALPS will require two additional items for run-time enabling of the NVIDIA IndeX libraries and license.

@biddisco
Copy link
Author

The PR can now be considered for merging. We support

eiger: zen2 : 
  paraview with OSMESA offscreen headless rendering, 
  python, 
  CDI for icon support, 
  raycasting with TBB  
  VTK-m filters using TBB
  + lots lots more
daint: gh200 : 
  paraview with EGL headless accelerated rendering, 
  nvidia index plugin, 
  python, 
  CDI support for icon
  TBB and raycasting
  CUDA enabled VTK-m filters 
  + more

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.0

1 similar comment
@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

4 similar comments
@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@biddisco
Copy link
Author

biddisco commented Sep 3, 2024

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@biddisco
Copy link
Author

biddisco commented Sep 3, 2024

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@biddisco
Copy link
Author

Please test this and consider it for deployment on our clusters

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.0

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.0

@biddisco
Copy link
Author

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.1

@biddisco
Copy link
Author

please note, paraview release has been bumped from 5.13.0 to 5.13.1

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.1

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=todi;uarch=gh200;uenv=paraview:5.13.1

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.1

@simonpintarelli
Copy link
Member

cscs-ci run alps;system=todi;uarch=gh200;uenv=paraview:5.13.1

@simonpintarelli
Copy link
Member

I've just tried to build it manually on eiger, there is an error compiling h5hut on zen2 too.

@simonpintarelli simonpintarelli self-requested a review November 25, 2024 20:38
@biddisco
Copy link
Author

PR comments addressed (hopefully) in commits pushed just now.

Copy link
Contributor

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work in figuring out all the details of this build! 💪

We are not going to polish this to be optimal, we will have a follow up PR in case to refine details (e.g. conduit spack package changes can be pushed to the public repo) and complete the cleanup.

I know we are targeting to merge a Paraview recipe as soon as possible, and I know it took very long to get here.

Thanks again!

Comment on lines +45 to +50
- blaspp
- eigen
- fftw
- lapackpp
- openblas
- proj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are blaspp, lapackpp, openblas, ... paraview dependencies? Or are there for another legit reason?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proj is needed, eigen is needed, the others were snuck in as part of my testing, but they don't do any harm. They can be removed, but IMHO they are harmless and useful for people creating plugins that need them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean...but CDI is required to build the ICON reader

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it is already in the spack official repo, this seems just a superfluous clone of it. In case it is not, it can stay here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem is that this was added before the CDI was available/functional in the general spack repo, if we remove this and switch to the built in one, then we needd to do a round of testing and checking to make sure that the cdi parallel load client/server etc etc works ok. It would be better to commit this stuff "as is" - and when we have reframe testing setup, remove all the obsolete things we added one by one as need/requests arise

@@ -0,0 +1,5 @@
bootstrap:
spec: gcc@11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any legit reason why we bootstrap gcc@12 with gcc@11?

Suggested change
spec: gcc@11
spec: gcc@12

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it couold be updated, it was there since the original 2023 PR commits, if we change it, we ought to rerun tests etc etc -- can we just leave it alone.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha - that's the eiger build only - the gh200 build was updated with gcc12, but I vaguely remember that eiger needed 11 - I will update it and trigger builds and see if all works.

@@ -0,0 +1,90 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @msimberg on this.

My 2cents

Does it do any harm to have them in the repo?

We might end up with tens of different scripts (there are already a good amount to support the point), one per system, that no one will maintain and probably use because they would have to study/change/update them first. So, maybe they look unharmful, but they already are harmful to the cleanliness of the recipe.

@biddisco
Copy link
Author

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

Copy link
Contributor

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything considered, I agree with what @biddisco said

It would be better to commit this stuff "as is" - and when we have reframe testing setup, remove all the obsolete things we added one by one as need/requests arise

as soon as reframe tests will be ready, we can eventually fix/cleanup/refine this in a next PR.

@biddisco
Copy link
Author

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

I tried adding openvdb, ( c.f. https://jira.cscs.ch/browse/SD-65739 )but it did not work, I have removed that commit and will work on that separately.

@biddisco
Copy link
Author

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.2

@msimberg
Copy link
Contributor

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@msimberg
Copy link
Contributor

cscs-ci run alps;system=eiger;uarch=zen2;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

5 similar comments
@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

biddisco commented Jun 2, 2025

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

@biddisco
Copy link
Author

biddisco commented Jun 4, 2025

cscs-ci run alps;system=daint;uarch=gh200;uenv=paraview:5.13.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants