Skip to content

Conversation

SamarthJ2004
Copy link
Contributor

Description

Adding content to the CL networking page (https://github.com/eth-protocol-fellows/protocol-studies/blob/main/docs/wiki/CL/cl-networking.md)

Took inspiration from the lecture 19 of study group and also added content based on the specs. Working on completing it. Need review and suggestions for the same.

@SamarthJ2004 SamarthJ2004 marked this pull request as draft March 30, 2025 11:32
@SamarthJ2004 SamarthJ2004 marked this pull request as ready for review April 12, 2025 22:42
@SamarthJ2004
Copy link
Contributor Author

Have added many sections, wanted to merge this as of now.

@SamarthJ2004
Copy link
Contributor Author

@taxmeifyoucan Do review this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo: It should be Noise instead of Noice and also we can add quic protocol which basically has built in Transport , Encryption and Multiplexing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can a section where quic basically replaces (TCP, Noise and MPLEX/YAMUX)

@guha-rahul
Copy link

@SamarthJ2004 you have to add specific words to the wordlist.txt to remove the spell check error for example "Req/Resp"

@SamarthJ2004
Copy link
Contributor Author

SamarthJ2004 commented Apr 22, 2025

@guha-rahul I had already added Req/Resp to wordlist. It's giving the error "/" can't be in a word. How do I get around this?

Copy link
Contributor

@taxmeifyoucan taxmeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments but haven't submitted the review, sorry for the delay, just noticed it now

@guha-rahul
Copy link

@SamarthJ2004 maybe try adding Req and Resp as seperate words?

@taxmeifyoucan
Copy link
Contributor

Thanks for updates! I think we can go ahead and merge this. Let me know or we confirm it at the call today

@SamarthJ2004
Copy link
Contributor Author

@taxmeifyoucan can I get this merged?

@raxhvl raxhvl merged commit 43911d9 into eth-protocol-fellows:main Jul 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants