chore: add gas accounting examples #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taxmeifyoucan @raxhvl, feel free to check out this PR whenever you get a chance ⚡ |
taxmeifyoucan
approved these changes
May 16, 2025
docs/wiki/EL/el-specs.md
Outdated
| ### Gas Accounting Examples | ||
| Up to this point, we've talked about EL post-merge gas mechanics in a variety of scenarios. Let's tie it all together with some examples. | ||
|
|
||
| Note: Gas parameters will differ depending upon if the contract was created before [EIP-1559](https://eips.ethereum.org/EIPS/eip-1559) was implemented. |
There was a problem hiding this comment.
I believe this should be based on tx type - whether user wallet is using 1559 or not.
What could be clearer here is that we have multiple types of transactions - legacy, 1559 and blob carrying
There was a problem hiding this comment.
There was a problem hiding this comment.
hey @taxmeifyoucan @raxhvl, great point that the gas params differ based on tx type. I updated the PR to account for this in latest commit 6656bb3.
Additionally, I made the comparisons in the PR to be more tabular instead of bullet points. Def more readable
shane-moore
force-pushed
the
chore/gas-examples
branch
from
9009e82 to
6656bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While reading through the EL specs section of the wiki, gas mechanics are mentioned throughout the page, so I figured it would be useful to have some examples that show how gas is deducted upfront, calcuated during the tsx, and then either burned/sent to proposer/refunded to tsx sender at different stages of the tsx lifecycle.