feat: make comments always visible with line separators#342
Open
CitaBFSUCS23 wants to merge 1 commit intoether:mainfrom
Open
feat: make comments always visible with line separators#342CitaBFSUCS23 wants to merge 1 commit intoether:mainfrom
CitaBFSUCS23 wants to merge 1 commit intoether:mainfrom
Conversation
CitaBFSUCS23
commented
Mar 21, 2026
CitaBFSUCS23
commented
- Comments are now always expanded without hover requirement
- Multiple comments on same line are stacked vertically
- Added red dashed line separator between different lines
- Added line number indicator (Line xx) on separators
- Fixed comment positioning using CSS relative layout
- Improved reply section spacing
- Comments are now always expanded without hover requirement - Multiple comments on same line are stacked vertically - Added red dashed line separator between different lines - Added line number indicator (Line xx) on separators - Fixed comment positioning using CSS relative layout - Improved reply section spacing
Member
|
Can you please upload a picture of before/after and explain which issue this solved? Has this been tested w/ responsive css IE mobile devices et al? |
Author
|
Cita或是Theta
***@***.***
It originated from the requirement that customers came to me for custom software didn't want comments to be collapsed. You know in the previous version, only one comment could be displayed on the same line, and it would expand when hovered over
More specifically, the solution we designed draws inspiration from the TrackChanges feature in Office Word
Perhaps users could be given the option to enable this feature by adding a field in setting.json in the future? I haven't tried it yet
It did not pass the test on IE. To be precise, I didn't even test it. My version of IE browser doesn't even support Etherpad itself, let alone this plugin
Mobile devices have been tested
原始邮件
发件人：John McLear ***@***.***>
发件时间：2026年3月22日 00:48
收件人：ether/ep_comments_page ***@***.***>
抄送：CitaBFSUCS23 ***@***.***>, Author ***@***.***>
主题：Re: [ether/ep_comments_page] feat: make comments always visible withline separators (PR #342)
JohnMcLear left a comment (ether/ep_comments_page#342)
Can you please upload a picture of before/after and explain which issue this solved?
Has this been tested w/ responsive css IE mobile devices et al?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.