Repository navigation
fix(pad): remove deleted pads from the welcome screen recent list #8237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+116
−0
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import {expect, test, Page} from '@playwright/test'; | ||
| import {randomUUID} from 'node:crypto'; | ||
| import {goToNewPad, goToPad} from '../helper/padHelper'; | ||
| import {showSettings} from '../helper/settingsHelper'; | ||
|
|
||
| // Issue #8201: after deleting a pad, the welcome screen kept listing it under | ||
| // "Recent pads" because the entry in localStorage was never removed. | ||
|
|
||
| const recentPadNames = async (page: Page): Promise<string[]> => page.evaluate( | ||
| () => JSON.parse(window.localStorage.getItem('recentPads') || '[]') | ||
| .map((p: {name: string}) => p.name)); | ||
|
|
||
| const waitForHome = async (page: Page) => page.waitForURL( | ||
| (url) => url.pathname === '/' || url.pathname.endsWith('/index.html'), {timeout: 10000}); | ||
|
|
||
| test.describe('recent pads after pad deletion', () => { | ||
| test.beforeEach(async ({context}) => { | ||
| await context.clearCookies(); | ||
| }); | ||
|
|
||
| test('creator deleting a pad removes it from the welcome screen', async ({page}) => { | ||
| const padId = await goToNewPad(page); | ||
| expect(await recentPadNames(page)).toContain(padId); | ||
|
|
||
| await showSettings(page); | ||
| page.once('dialog', (d) => d.accept()); | ||
| await page.locator('#delete-pad').click(); | ||
| await waitForHome(page); | ||
|
|
||
| expect(await recentPadNames(page)).not.toContain(padId); | ||
| await expect(page.locator('.recent-pad a', {hasText: padId})).toHaveCount(0); | ||
| }); | ||
|
|
||
| test('deleting with a token on a second device removes it from that device', async ({ | ||
| page, browser, | ||
| }) => { | ||
| const padId = `FRONTEND_TESTS${randomUUID()}`; | ||
| await page.goto(`http://localhost:9001/p/${padId}`); | ||
| await page.waitForSelector('#editorcontainer.initialized'); | ||
| const token = await page.locator('#deletiontoken-value').inputValue(); | ||
| await page.locator('#deletiontoken-ack').click(); | ||
|
|
||
| const context2 = await browser.newContext(); | ||
| const page2 = await context2.newPage(); | ||
| await goToPad(page2, padId); | ||
| expect(await recentPadNames(page2)).toContain(padId); | ||
|
|
||
| await showSettings(page2); | ||
| await page2.locator('#delete-pad-with-token > summary').click(); | ||
| await page2.locator('#delete-pad-token-input').fill(token); | ||
| page2.once('dialog', (d) => d.accept()); | ||
| await page2.locator('#delete-pad-token-submit').click(); | ||
| await waitForHome(page2); | ||
|
|
||
| expect(await recentPadNames(page2)).not.toContain(padId); | ||
| await expect(page2.locator('.recent-pad a', {hasText: padId})).toHaveCount(0); | ||
| // The creator's still-open tab was disconnected with reason "deleted" and | ||
| // must also forget the pad. | ||
| await expect.poll(() => recentPadNames(page)).not.toContain(padId); | ||
|
|
||
| await context2.close(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.