Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating absolute prestate and preimage files for permissionless proofs #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Generating absolute prestate and preimage files for permissionless proofs #1610
Changes from 6 commits
92df61e
e899514
9bcd1d6
4656912
757c2ba
6a0c94f
507563f
e85b224
6825305
d3fd8a6
33ac6d3
0d6f667
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For production chains you would normally want the latest finalized release (e.g.
v1.6.1
not an rc). The latest finalized release is typically what is running on op-mainnet - testnets and devnets will use rc's.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required.
make reproducible-prestate
will build everything necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessarily true. The prestates contain the config for chains that were in the version of the registry imported to the monorepo when the prestate was tagged. Just because a prestate is listed in the superchain-registry doesn't mean it is safe to use for a chain in the registry (it may have been created before the chain was added or it may not contain the most up to date config for the chain).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a very hacky little tool for checking if a prestate listed in the superchain registry includes the latest config for a chain:
https://github.com/ethereum-optimism/optimism/blob/273fd6abd4a92824e05f3daa9322b0c8add9e843/op-chain-ops/cmd/check-prestate/README.md#L1
It's just a quick tool for us and not very user friendly.