p2p/enode: add back DNS hostname resolution at parsing time #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/fix-p2p-dns
branch
from
e6632af to
566ed51
Compare
- removed in ethereum/go-ethereum#30822 in favor of on-demand runtime dialling - reported to have removed bootnodes DNS resolution at ethereum/go-ethereum#31208 - possibly broke DNS resolution for other methods of adding peers
sebastianst
force-pushed
the
seb/fix-p2p-dns
branch
from
566ed51 to
f080af8
Compare
|
@sebastianst When do you plan to merge this PR? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix until upstream has implemented a proper fix.
Tests
None added, code copied from ethereum/go-ethereum#30822