Skip to content

p2p: remove redundant discv5 dialer resource #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: optimism
Choose a base branch
from

Conversation

islishude
Copy link
Contributor

It was added at 5fcc6e0

but since op-geth has merged the geth 1.15.x, this line is not necessary anymore

op-geth/eth/backend.go

Lines 499 to 503 in 28ddc5e

// Add DHT nodes from discv5.
if s.p2pServer.DiscoveryV5() != nil {
filter := eth.NewNodeFilter(s.blockchain)
iter := enode.Filter(s.p2pServer.DiscoveryV5().RandomNodes(), filter)
s.discmix.AddSource(iter)

op-geth/p2p/server.go

Lines 500 to 505 in 28ddc5e

for _, proto := range srv.Protocols {
if proto.DialCandidates != nil && !added[proto.Name] {
srv.discmix.AddSource(proto.DialCandidates)
added[proto.Name] = true
}
}

@islishude islishude requested a review from a team as a code owner March 17, 2025 04:29
@islishude islishude requested a review from geoknee March 17, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant