Skip to content

interop: Remove checkInterop from Block Building Path #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: optimism
Choose a base branch
from

Conversation

axelKingsley
Copy link
Contributor

Through recent transaction handling designs, we have decided that putting a blocking RPC call against every interop transaction during block building is inappropriate. For the following reasons:

  • It costs excessive time during building
  • Transactions are filtered at mempool ingress already
    • The only way a transaction would go from pass->fail in this time is if a remote reorg occurred on the referenced chain.
  • Remote reorgs can still occur after this check, and even after this block is published, so we don't gain 100% accuracy by having this check here.

Design
FMA

We may want to include the recurring (timer) checks here in this same PR, but I wanted to kick off the work with this change, which is purely removal.

@axelKingsley axelKingsley requested a review from a team as a code owner April 16, 2025 19:17
@protolambda
Copy link
Collaborator

protolambda commented Apr 28, 2025

This needs to be scrutinized very closely, due to reorg behavior (note: the local chain, not the remote chain) breaking pre-validation assumptions.

@axelKingsley
Copy link
Contributor Author

This needs to be scrutinized very closely, due to reorg behavior (note: the local chain, not the remote chain) breaking pre-validation assumptions.

Ah right, the behavior in which all transactions from a reorged block get dumped back into the mempool. I would hope that mempool ingress would catch those, but I remember you and I talking about how we need to confirm this.

@protolambda protolambda added this to the Interop RC Beta milestone May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants