interop: use the pending time instead of the unsafe time for executing descriptors #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
force-pushed
the
joshklop/fix-interop-current-block
branch
from
649eb6c to
926a2ff
Compare
tynes
reviewed
May 13, 2025
joshklop
force-pushed
the
joshklop/fix-interop-current-block
branch
from
926a2ff to
2e452cf
Compare
axelKingsley
approved these changes
May 13, 2025
joshklop
force-pushed
the
joshklop/fix-interop-current-block
branch
from
2e452cf to
ec3f4bb
Compare
…g descriptors Previously, the ingress filter [assigned] the [latest timestamp] to exec descriptors. This unnecessarily delayed executing messages by one block when the supervisor used a stringent [access list policy], as in the [reference implementation]. This commit fixes the issue by using the pending timestamp instead of the unsafe timestamp. [assigned]: https://github.com/ethereum-optimism/op-geth/blob/e605d07bde55b02f9e0309c330fb87500d80d06f/core/txpool/ingress_filters.go#L48-L58 [latest timestamp]: https://github.com/ethereum-optimism/op-geth/blob/e605d07bde55b02f9e0309c330fb87500d80d06f/eth/interop.go#L20-L31 [access list policy]: https://specs.optimism.io/interop/supervisor.html#access-list-checks [reference implementation]: https://github.com/ethereum-optimism/optimism/blob/23c1fef1f0fe6b626c987eecbfa91fd5e0b66fb0/op-supervisor/supervisor/types/types.go#L344-L346
joshklop
force-pushed
the
joshklop/fix-interop-current-block
branch
from
ec3f4bb to
23442bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the ingress filter assigned the latest timestamp to exec descriptors.
This unnecessarily delayed executing messages by one block when the supervisor used a stringent access list policy, as in the reference implementation.
This commit fixes the issue by using the pending timestamp instead of the unsafe timestamp.
Fixes #603
Testing
I didn't add a regression test. If one is desired, please let me know where the best place for one might be and I'll happily add it.