Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
slog.Logger
TraceContext
.CritContext
(crits are discouraged, and we would never want to filter from output based on context)WriteCtx
to complement the existingWrite
methodslog.Attr
in regular log callsWrite
Crit
more nicelyTests
slog.Attr
can be used in regular log callsAdditional context
This helps us remove a big logging hack in our monorepo testing, so that we can do context-logging and test tracing properly.
We can also attach the devtest test-scope context to our loggers, so logs can be attributed to scopes with context.
And we can attach attributes like service-ID to package-level loggers, so we can make the log-handler easily filter down to only logs with relevant context.
Metadata