eth, cmd: add RollupNetrestrictTxPoolGossipFlag #706
+165
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may update the forkdiff(https://github.com/ethereum-optimism/op-geth/blob/optimism/fork.yaml) to track the geth diff. |
nonsense
force-pushed
the
nonsense/netrestrict-txpool-gossip
branch
from
e06f64a to
e3042c2
Compare
pcw109550
reviewed
Oct 27, 2025
There was a problem hiding this comment.
This only takes care of outbound connections. To truly restrict tx gossiping, we must also prohibit inbound connections from disallowed peers. In other words, external peers' transactions must not be gossiped in to the node.
We may need to explore other control flows that may create outbound connections for tx gossiping.
|
Worth to mention that the new flag will be the same information restriction level with |
nonsense
force-pushed
the
nonsense/netrestrict-txpool-gossip
branch
from
ce00797 to
edf0d1e
Compare
…outgoing message.
nonsense
force-pushed
the
nonsense/netrestrict-txpool-gossip
branch
from
edf0d1e to
2e01ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a
rollup.netrestricttxpoolgossipflag, so that the node gossips and accepts gossips of transactions only to a restricted set, if one is specified.If the flag is not specific, no peers are filtered, i.e. gossiping works for all peers.
RollupNetrestrictTxPoolGossipFlagflagTxGossipNetRestrictto theBackendand propagates it to everyPeer.p2p.Sendcalls (outgoing messages) as well as handling of incoming messages related to transactions.