Run go run build/ci.go check_generate #741
Merged
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
reviewed
Jan 7, 2026
Unfortunately, the check_generate script doesn't consider eth/ethconfig, so ci can't catch this.
joshklop
force-pushed
the
joshklop/check-generate
branch
from
a7e8162 to
b6420b9
Compare
joshklop
added a commit
to joshklop/go-ethereum
that referenced
this pull request
Jan 7, 2026
If an excluded directory was the prefix of a file (e.g., .git and .gitattributes), the returned file.SkipDir error would instruct filepath.WalkDir to abort. Originally discussed in ethereum-optimism/op-geth#741
geoknee
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the check_generate script doesn't consider eth/ethconfig, so ci can't catch this.