Skip to content

[WIP] L1 nonce for consensus events (deposits + config updates) #13539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Dec 27, 2024

Description

Implementation of ethereum-optimism/specs#330 (comment), more details coming soon...

Tracker issue: #13543

Tests

Additional context

Metadata

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 3 times, most recently from bb0c03c to 116598a Compare December 27, 2024 19:54
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 56.98925% with 120 lines in your changes missing coverage. Please review.

Project coverage is 46.45%. Comparing base (ed1e341) to head (073611d).
Report is 271 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/derive/l1_block_info.go 58.82% 18 Missing and 10 partials ⚠️
op-node/rollup/derive/deposit_log.go 40.47% 25 Missing ⚠️
op-service/eth/types.go 0.00% 17 Missing ⚠️
op-node/rollup/derive/system_config.go 25.00% 9 Missing ⚠️
op-node/rollup/derive/attributes.go 38.46% 5 Missing and 3 partials ⚠️
op-node/rollup/derive/payload_util.go 0.00% 6 Missing ⚠️
op-node/rollup/sequencing/sequencer.go 0.00% 3 Missing and 1 partial ⚠️
op-node/rollup/types.go 63.63% 4 Missing ⚠️
op-chain-ops/genesis/config.go 62.50% 3 Missing ⚠️
op-node/rollup/attributes/engine_consolidate.go 0.00% 3 Missing ⚠️
... and 8 more

❗ There is a different number of reports uploaded between BASE (ed1e341) and HEAD (073611d). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ed1e341) HEAD (073611d)
2 1
cannon-go-tests-32 2 1
cannon-go-tests-64 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13539       +/-   ##
============================================
- Coverage    78.18%   46.45%   -31.74%     
============================================
  Files          178     1030      +852     
  Lines        10667    88504    +77837     
============================================
+ Hits          8340    41114    +32774     
- Misses        2137    44316    +42179     
- Partials       190     3074     +2884     
Flag Coverage Δ
cannon-go-tests-32 61.89% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.54% <ø> (-1.65%) ⬇️
contracts-bedrock-tests 94.50% <87.93%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/batcher/sync_actions.go 26.80% <ø> (ø)
op-chain-ops/genesis/layer_two.go 0.00% <ø> (ø)
op-chain-ops/interopgen/recipe.go 75.09% <100.00%> (ø)
op-node/rollup/chain_spec.go 70.94% <100.00%> (ø)
op-node/rollup/derive/deposits.go 71.87% <100.00%> (ø)
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 100.00% <100.00%> (ø)
.../contracts-bedrock/src/L1/OptimismPortalJovian.sol 100.00% <100.00%> (ø)
...s/contracts-bedrock/src/L1/SystemConfigInterop.sol 100.00% <100.00%> (ø)
...es/contracts-bedrock/src/L1/SystemConfigJovian.sol 100.00% <100.00%> (ø)
...ckages/contracts-bedrock/src/L2/L1BlockInterop.sol 100.00% <100.00%> (+6.45%) ⬆️
... and 18 more

... and 847 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 14 times, most recently from b299bc9 to b38eac2 Compare December 29, 2024 03:35
@mdehoog mdehoog changed the title [WIP] Deposit queue [WIP] L1 nonce for consensus events (deposits + config updates) Dec 29, 2024
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 11 times, most recently from 48ac835 to 5486868 Compare December 31, 2024 01:06
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Feb 20, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@mdehoog mdehoog removed the S-stale Status: Will be closed unless there is activity label Feb 21, 2025
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 11 times, most recently from 98ba164 to 073611d Compare February 22, 2025 07:43
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Mar 8, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@mdehoog mdehoog removed the S-stale Status: Will be closed unless there is activity label Mar 8, 2025
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Mar 23, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@mdehoog mdehoog removed the S-stale Status: Will be closed unless there is activity label Mar 23, 2025
@mdehoog mdehoog force-pushed the michael/deposit-queue branch from 073611d to c2d6a0e Compare March 29, 2025 03:16
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Apr 12, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-stale Status: Will be closed unless there is activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants