feat: remove v1 dispute games #18714
Open
+444
−5,162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevennevins
force-pushed
the
feat/remove-v1-dispute-games
branch
from
d2e19fe to
f816ff4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18714 +/- ##
===========================================
+ Coverage 73.97% 81.75% +7.78%
===========================================
Files 190 133 -57
Lines 11322 6921 -4401
===========================================
- Hits 8375 5658 -2717
+ Misses 2801 1263 -1538
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stevennevins
force-pushed
the
feat/remove-v1-dispute-games
branch
from
0c7e380 to
96aab06
Compare
Remove legacy V1 dispute game contracts and update all references to use V2 contracts. V2 is now the only implementation. Deleted: - src/dispute/FaultDisputeGame.sol (V1) - src/dispute/PermissionedDisputeGame.sol (V1) - interfaces/dispute/IFaultDisputeGame.sol (V1) - interfaces/dispute/IPermissionedDisputeGame.sol (V1) Updated all imports and references in: - OPContractsManager and related deploy scripts - AnchorStateRegistry - Test files Closes #18584
Move V2 dispute game contracts out of nested /v2/ folder and rename to canonical names since V2 is now the only implementation. File moves: - src/dispute/v2/FaultDisputeGameV2.sol → src/dispute/FaultDisputeGame.sol - src/dispute/v2/PermissionedDisputeGameV2.sol → src/dispute/PermissionedDisputeGame.sol - interfaces/dispute/v2/IFaultDisputeGameV2.sol → interfaces/dispute/IFaultDisputeGame.sol - interfaces/dispute/v2/IPermissionedDisputeGameV2.sol → interfaces/dispute/IPermissionedDisputeGame.sol Renames: - FaultDisputeGameV2 → FaultDisputeGame - PermissionedDisputeGameV2 → PermissionedDisputeGame - IFaultDisputeGameV2 → IFaultDisputeGame - IPermissionedDisputeGameV2 → IPermissionedDisputeGame Updated all imports and references across ~50 files.
Bytecode changed due to metadata differences from V2 contract removal.
…te snapshots - Rename faultDisputeGameV2Impl → faultDisputeGameImpl in Implementations struct - Rename permissionedDisputeGameV2Impl → permissionedDisputeGameImpl - Rename V2 functions: _registerPermissionedGameV2 → _registerPermissionedGame - Update setNewPermissionedGameImplV2 → setNewPermissionedGameImpl - Update setNewPermissionlessGameImplV2 → setNewPermissionlessGameImpl - Fix stale comment in FaultDisputeGame.sol (240 → 244 bytes) - Regenerate ABI snapshots with correct struct member names - Update Go files in op-deployer and op-chain-ops
stevennevins
force-pushed
the
feat/remove-v1-dispute-games
branch
from
1a90d27 to
c00f7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #18181, to clean up all references to V1 dispute games and make the v2 games the canonical dispute games.
Tests
Updates to existing test coverage for rename
Additional context
n/a
Metadata
Completes #18584