op-acceptance-tests: Add EL eth_simulate acceptance test #18724
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #18724 +/- ##
===========================================
- Coverage 73.82% 66.58% -7.25%
===========================================
Files 189 55 -134
Lines 11252 4031 -7221
===========================================
- Hits 8307 2684 -5623
+ Misses 2799 1203 -1596
+ Partials 146 144 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
geoknee
commented
Jan 7, 2026
Add ReturnFullTransactions to simulation params and require the RPC call to succeed. Assert exactly one block and one transaction are returned and verify the transaction is a dynamic fee tx (type 0x2).
joshklop
reviewed
Jan 7, 2026
Decode blobGasUsed with hexutil and assert it's nonzero to ensure eth_simulateV1 can estimate DA size. Also fix a comment typo (bock -> block).
Call eth_simulateV1 with block "0x0" (genesis) and require an error to ensure the method cannot be used on the genesis block move test under "base" directory
geoknee
changed the title
joshklop
approved these changes
Jan 8, 2026
| ) | ||
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101603.6-rc.1 | ||
| replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101604.1-0.20260108133432-e4826126d221 |
Contributor
There was a problem hiding this comment.
Will this make develop non-release ready?
Contributor
Author
There was a problem hiding this comment.
Let's keep this convo open and not merge the PR until we have an RC to point to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this to fail, but it passes against ethereum-optimism/op-geth#732.
Merge plan:
eth_simulateV1after Jovian fork op-geth#732