test: DeployImplementations and opchain additional tests #18725
+534
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add test cases for DeployOPChain * chore: remove unused helper function in DeployOPChain * test: add unit testing for opcm version on the makeDCI function * test: add challenger check for address(0) * chore: add natspec for DeployImplementations.s.sol functions * test: move challenger = address(0) test to test_run_nullInput_reverts * refactor: removes hard-coded init bond * chore: add natspec and proper names for internal functions DeployOPChain * test: checks for additional assertions for the DeployOPChain::runWithBytes * test: use DEFAULT_INIT_BOND * test: add natspec for DeployImplementations.t.sol * refactor: remove one liner helper * fix: add revert if v2 enabled but not deployed * fix: add revert if v2 enabled but not deployed && add expect error msg test * fix: add revert when opcmAddr is zero --------- Co-authored-by: niha <[email protected]>
Contributor
|
/ci authorize 2477a2d |
Contributor
|
/ci authorize 54c778a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DeployImplementations.s.solmakeDCIto test correctDeployOPChainInputis produced.DeployImplementations.s.sol