test(contracts): improve OptimismSuperchainERC20Beacon test coverage#19446
Open
devin-ai-integration[bot] wants to merge 2 commits intodevelopfrom
Open
test(contracts): improve OptimismSuperchainERC20Beacon test coverage#19446devin-ai-integration[bot] wants to merge 2 commits intodevelopfrom
devin-ai-integration[bot] wants to merge 2 commits intodevelopfrom
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19446 +/- ##
===========================================
+ Coverage 11.7% 79.4% +67.7%
===========================================
Files 676 138 -538
Lines 71049 6699 -64350
===========================================
- Hits 8322 5325 -2997
+ Misses 62583 1374 -61209
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
smartcontracts
approved these changes
Mar 9, 2026
1fe5400 to
9abe2b1
Compare
…n test Rename test_implementation_isCorrect_works to test_implementation_succeeds to follow the [method]_[functionName]_[outcome] naming convention.
…ERC20Beacon Add OptimismSuperchainERC20Beacon_Version_Test with SemverComp.parse() to validate the version string follows proper semver format.
9abe2b1 to
e9ee660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small improvements to
OptimismSuperchainERC20Beacon.t.sol:test_implementation_isCorrect_works→test_implementation_isCorrect_succeedsto follow the[method]_[functionName]_[scenario]_[outcome]convention (outcomes must besucceeds/reverts/fails, neverworks).OptimismSuperchainERC20Beacon_Version_Testwithtest_version_validSemver_succeedsusingSemverComp.parse()— follows the same pattern asL1FeeVault,BaseFeeVault, and other beacon/vault test files.Review & Testing Checklist for Human
ISemvercast on the beacon predeploy address is correct —OptimismSuperchainERC20BeaconimplementsISemverso this should work, but all tests are currently skipped (vm.skip(true)) and haven't been validated against a live deploymentSemverComp.parse()pattern matches the convention used in other test files (e.g.,L1FeeVault_Version_Test,BaseFeeVault_Version_Test)Notes
vm.skip(true)inOptimismSuperchainERC20Beacon_TestInitpending re-integration of the beacon contract. This PR doesn't change that behavior.just prpasses locally (all 16/16 checks).Link to Devin session: https://app.devin.ai/sessions/67da260877434a81a3340884b6bdff59
Requested by: @aliersh