Skip to content

test(contracts): improve OptimismSuperchainERC20Beacon test coverage#19446

Open
devin-ai-integration[bot] wants to merge 2 commits intodevelopfrom
ai/improve-optimism-superchain-erc20-beacon-coverage
Open

test(contracts): improve OptimismSuperchainERC20Beacon test coverage#19446
devin-ai-integration[bot] wants to merge 2 commits intodevelopfrom
ai/improve-optimism-superchain-erc20-beacon-coverage

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 9, 2026

Summary

Two small improvements to OptimismSuperchainERC20Beacon.t.sol:

  1. Naming fix: Renamed test_implementation_isCorrect_workstest_implementation_isCorrect_succeeds to follow the [method]_[functionName]_[scenario]_[outcome] convention (outcomes must be succeeds/reverts/fails, never works).
  2. Version coverage: Added OptimismSuperchainERC20Beacon_Version_Test with test_version_validSemver_succeeds using SemverComp.parse() — follows the same pattern as L1FeeVault, BaseFeeVault, and other beacon/vault test files.

Review & Testing Checklist for Human

  • Verify the ISemver cast on the beacon predeploy address is correct — OptimismSuperchainERC20Beacon implements ISemver so this should work, but all tests are currently skipped (vm.skip(true)) and haven't been validated against a live deployment
  • Confirm the SemverComp.parse() pattern matches the convention used in other test files (e.g., L1FeeVault_Version_Test, BaseFeeVault_Version_Test)

Notes

  • All tests are skipped via vm.skip(true) in OptimismSuperchainERC20Beacon_TestInit pending re-integration of the beacon contract. This PR doesn't change that behavior.
  • just pr passes locally (all 16/16 checks).

Link to Devin session: https://app.devin.ai/sessions/67da260877434a81a3340884b6bdff59
Requested by: @aliersh

@devin-ai-integration devin-ai-integration bot requested review from a team and mds1 March 9, 2026 07:14
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.4%. Comparing base (85e4935) to head (e9ee660).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19446      +/-   ##
===========================================
+ Coverage     11.7%    79.4%   +67.7%     
===========================================
  Files          676      138     -538     
  Lines        71049     6699   -64350     
===========================================
- Hits          8322     5325    -2997     
+ Misses       62583     1374   -61209     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 79.4% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 538 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devin-ai-integration devin-ai-integration bot force-pushed the ai/improve-optimism-superchain-erc20-beacon-coverage branch from 1fe5400 to 9abe2b1 Compare April 9, 2026 07:15
…n test

Rename test_implementation_isCorrect_works to test_implementation_succeeds to follow the [method]_[functionName]_[outcome] naming convention.
…ERC20Beacon

Add OptimismSuperchainERC20Beacon_Version_Test with SemverComp.parse() to validate the version string follows proper semver format.
@devin-ai-integration devin-ai-integration bot force-pushed the ai/improve-optimism-superchain-erc20-beacon-coverage branch from 9abe2b1 to e9ee660 Compare April 13, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants