fix(kona): use correct precompile versions for Jovian and post-Jovian specs#20003
Open
sebastianst wants to merge 1 commit intodevelopfrom
Open
fix(kona): use correct precompile versions for Jovian and post-Jovian specs#20003sebastianst wants to merge 1 commit intodevelopfrom
sebastianst wants to merge 1 commit intodevelopfrom
Conversation
… specs The FPVM precompile provider had two bugs in spec-to-precompile mapping: 1. Non-accelerated precompiles: JOVIAN was grouped with ISTHMUS, returning isthmus() instead of jovian(). The jovian() set includes input size restrictions on 4 variable-input precompiles. 2. Accelerated precompiles: INTEROP and OSAKA (post-Jovian forks) were grouped with ISTHMUS, returning accelerated_isthmus() instead of accelerated_jovian(). This would cause wrong gas costs once those forks activate. Both match blocks now correctly map ISTHMUS to its own precompile set and JOVIAN/INTEROP/OSAKA to the Jovian set, matching the reference implementation in op_revm::OpPrecompiles. Fixes ethereum-optimism/optimism-private#470 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20003 +/- ##
===========================================
+ Coverage 11.6% 76.6% +65.0%
===========================================
Files 677 505 -172
Lines 71141 64101 -7040
===========================================
+ Hits 8277 49130 +40853
+ Misses 62720 14971 -47749
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
theochap
approved these changes
Apr 9, 2026
op-will
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isthmus()— now correctly maps tojovian()(which includes input size restrictions on 4 variable-input precompiles)accelerated_isthmus()— now correctly map toaccelerated_jovian(), matching the reference impl inop_revm::OpPrecompilescore::ptr::eqFixes ethereum-optimism/optimism-private#470
Test plan
test_post_jovian_specs_use_jovian_precompiles— verifies JOVIAN/INTEROP/OSAKA all point tojovian()precompiles and ISTHMUS points toisthmus()kona-clienttests passjust f, clean compile with no warnings🤖 Generated with Claude Code