fix(kona): use L1 origin timestamp for brotli activation check#20004
Open
sebastianst wants to merge 1 commit intodevelopfrom
Open
fix(kona): use L1 origin timestamp for brotli activation check#20004sebastianst wants to merge 1 commit intodevelopfrom
sebastianst wants to merge 1 commit intodevelopfrom
Conversation
The BatchReader Fjord check for brotli decompression used the untrusted batch timestamp instead of the L1 origin timestamp. A malicious batcher could craft a batch with a pre-Fjord timestamp inside a post-Fjord brotli-compressed channel, causing kona to discard the channel while op-node (which uses the origin timestamp) accepts it — a consensus deviation. Store the L1 origin timestamp in BatchReader at construction time and use it for the is_fjord_active check, matching op-node behavior. Fixes ethereum-optimism/optimism-private#485 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
theochap
approved these changes
Apr 10, 2026
op-will
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchReadernow stores the L1 origin timestamp at construction, using it for the Fjord brotli activation check instead of the untrusted batch timestampBatchReaderthat claimed L1 inclusion was provided at creation time (now it actually is)Fixes ethereum-optimism/optimism-private#485
Test plan
kona-protocolbatch reader tests pass (4/4)kona-derivechannel reader tests pass (7/7)kona-derivebatch queue tests pass (20/20)kona-protocol, formatted withjust f🤖 Generated with Claude Code