chore(deployer): remove OPCMv1 migration, upgrade, and dev feature code#20024
Open
smartcontracts wants to merge 1 commit intodevelopfrom
Open
chore(deployer): remove OPCMv1 migration, upgrade, and dev feature code#20024smartcontracts wants to merge 1 commit intodevelopfrom
smartcontracts wants to merge 1 commit intodevelopfrom
Conversation
…put fields Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20024 +/- ##
===========================================
+ Coverage 11.7% 79.4% +67.7%
===========================================
Files 676 138 -538
Lines 71016 6699 -64317
===========================================
- Hits 8322 5325 -2997
+ Misses 62550 1374 -61176
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all remaining OPCMv1 code from op-deployer and related packages. Follow-up to #19795 (Solidity-side removal) and #19919 (mechanical struct/compat cleanup).
MigrateInputV1,GameParameters,OPChainConfigstructs,EncodedMigrateInputV1(), v1 branch inMigrateCLI(), v1-specific CLI flags (ProposerFlag,ChallengerFlag,DisputeAbsolutePrestate{Cannon,CannonKona}Flag, etc.)manage/add_game_type.go,opcm/add_game_type.goand tests (subsumed byadd-game-type-v2/upgrade)embedded.OPChainConfig,EncodedOpChainConfigs(), v1 branch inUpgrade()DeployImplementationsOutput.Opcmand 5 other v1 inner contract fields; corresponding SolidityDeployImplementations.s.solOutput struct fieldsOpcmGameTypeAdderImpl,OpcmDeployerImpl,OpcmUpgraderImplfromImplementationsContracts;Opcmfrominteropgen.ImplementationsIsVersionAtLeast()— sole caller removed22 files changed, +168 / -2,111 lines (net -1,943)
Test plan
go build ./...passesgo vet ./op-deployer/... ./op-chain-ops/...passes🤖 Generated with Claude Code