Skip to content

fix(interopgen): honor InteropOffset when setting UseInterop at genesis#20029

Draft
maurelian wants to merge 1 commit intodevelopfrom
fix/interopgen-honor-interop-offset
Draft

fix(interopgen): honor InteropOffset when setting UseInterop at genesis#20029
maurelian wants to merge 1 commit intodevelopfrom
fix/interopgen-honor-interop-offset

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Summary

GenesisL2 unconditionally set UseInterop = true and enabled the Interop dev feature bit for every multi-chain setup, ignoring the configured InteropOffset. When InteropOffset > 0, this created an impossible configuration: the Solidity fork number is pre-Interop, but genesis was told to install Interop contracts and feature flags anyway.

Now UseInterop and DevFeatureBitmap are derived from whether Interop actually activates at genesis (InteropOffset == 0), not from whether the world has multiple chains.

Test plan

  • Existing TestInteropDevRecipe (offset=0, 2 chains) passes — behavior unchanged
  • TestInteropUpgrade (offset=3, 2 chains) can now build genesis without conflict
  • TestInteropGenesisActivation (offset=0) passes — behavior unchanged

GenesisL2 unconditionally set UseInterop=true for multi-chain setups,
ignoring InteropOffset. This created an impossible config when
InteropOffset > 0: the selected fork is pre-Interop but genesis was
told to install Interop contracts and feature flags anyway.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.5%. Comparing base (45287f7) to head (7c15e95).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20029      +/-   ##
===========================================
+ Coverage     11.7%    74.5%   +62.8%     
===========================================
  Files          676      193     -483     
  Lines        71016    10734   -60282     
===========================================
- Hits          8322     8002     -320     
+ Misses       62550     2588   -59962     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.3% <ø> (ø)
contracts-bedrock-tests 79.4% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 483 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant