fix(interopgen): honor InteropOffset when setting UseInterop at genesis#20029
Draft
fix(interopgen): honor InteropOffset when setting UseInterop at genesis#20029
Conversation
GenesisL2 unconditionally set UseInterop=true for multi-chain setups, ignoring InteropOffset. This created an impossible config when InteropOffset > 0: the selected fork is pre-Interop but genesis was told to install Interop contracts and feature flags anyway.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20029 +/- ##
===========================================
+ Coverage 11.7% 74.5% +62.8%
===========================================
Files 676 193 -483
Lines 71016 10734 -60282
===========================================
- Hits 8322 8002 -320
+ Misses 62550 2588 -59962
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenesisL2unconditionally setUseInterop = trueand enabled the Interop dev feature bit for every multi-chain setup, ignoring the configuredInteropOffset. WhenInteropOffset > 0, this created an impossible configuration: the Solidity fork number is pre-Interop, but genesis was told to install Interop contracts and feature flags anyway.Now
UseInteropandDevFeatureBitmapare derived from whether Interop actually activates at genesis (InteropOffset == 0), not from whether the world has multiple chains.Test plan
TestInteropDevRecipe(offset=0, 2 chains) passes — behavior unchangedTestInteropUpgrade(offset=3, 2 chains) can now build genesis without conflictTestInteropGenesisActivation(offset=0) passes — behavior unchanged