Skip to content

test(contracts): improve OptimismSuperchainERC20Beacon test coverage #20032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: develop
Choose a base branch
from
+19 −5
Open

test(contracts): improve OptimismSuperchainERC20Beacon test coverage #20032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6244dfd
refactor(test): fix naming convention in OptimismSuperchainERC20Beaco…
devin-ai-integration[bot] Apr 13, 2026
e9ee660
test(contracts): add version format validation for OptimismSuperchain…
devin-ai-integration[bot] Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions packages/contracts-bedrock/test/L2/OptimismSuperchainERC20Beacon.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@
pragma solidity 0.8.15;

// Testing utilities
import { CommonTest } from "test/setup/CommonTest.sol";
import {CommonTest} from "test/setup/CommonTest.sol";

// Libraries
import { Predeploys } from "src/libraries/Predeploys.sol";
import { IBeacon } from "@openzeppelin/contracts/proxy/beacon/IBeacon.sol";
import {Predeploys} from "src/libraries/Predeploys.sol";
import {SemverComp} from "src/libraries/SemverComp.sol";
import {IBeacon} from "@openzeppelin/contracts/proxy/beacon/IBeacon.sol";

// Interfaces
import {ISemver} from "interfaces/universal/ISemver.sol";

/// @title OptimismSuperchainERC20Beacon_TestInit
/// @notice Reusable test initialization for `OptimismSuperchainERC20Beacon` tests.
Expand All @@ -25,9 +29,19 @@ abstract contract OptimismSuperchainERC20Beacon_TestInit is CommonTest {
/// @notice Contract for testing the `implementation` function of the
/// `OptimismSuperchainERC20Beacon` contract.
contract OptimismSuperchainERC20Beacon_Implementation_Test is OptimismSuperchainERC20Beacon_TestInit {
/// @notice Test that calling the implementation function returns the correct implementation address.
function test_implementation_isCorrect_works() public view {
/// @notice Test that the implementation returns the correct address.
function test_implementation_succeeds() public view {
IBeacon beacon = IBeacon(Predeploys.OPTIMISM_SUPERCHAIN_ERC20_BEACON);
assertEq(beacon.implementation(), Predeploys.OPTIMISM_SUPERCHAIN_ERC20);
}
}

/// @title OptimismSuperchainERC20Beacon_Version_Test
/// @notice Tests the `version` function of the
/// `OptimismSuperchainERC20Beacon` contract.
contract OptimismSuperchainERC20Beacon_Version_Test is OptimismSuperchainERC20Beacon_TestInit {
/// @notice Tests that version returns a valid semver string.
function test_version_succeeds() external view {
SemverComp.parse(ISemver(Predeploys.OPTIMISM_SUPERCHAIN_ERC20_BEACON).version());
}
}
Loading