-
Couldn't load subscription status.
- Fork 109
Worldchain Sepolia U13 to U16a Upgrade #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: we do NOT plan to merge this PR, and are just using it to generate the calldata, then can close it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct @mds1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folder is called "u13 to u16a" but PR title is "u12 to u16a" — I think "u12 to u16a" is correct but want to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the PR title. For the past upgrades we didn't count the current contract version so it would be U13>U16a (they are on U12).
To confirm with contract versions: they are on contract version 1.8.0 and the calldata in this PR would bring them to 4.1.0
| # PDDG-DWETH-30 : Permissioned dispute game delayed WETH owner mismatch. | ||
| # PDDG-130: The challenger is not the standard one. | ||
| # PLDG-10 : Permissionless dispute game implementation not found. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of v4 these two addresses should be the same, let's try that and see if CI still passes:
| StandardValidatorV410 = "0x3bb6437aba031afbf9cb3538fa064161e2bf2d78" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the task is already using OPCM 410 0x3bb6437aba031afbf9cb3538fa064161e2bf2d78 and the relative standard validator 0x7b4d2a02d5fa6c7c98d835d819956ebb876ff439. Should these be different updated addresses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard validator is now integrated with the OPCM, so their addresses can match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, CI looks good
This task is used to generate the calldata necessary to bring Worldchain Sepolia from contract version 1.8.0 to 4.1.0