U17 Base Sepolia #1267
U17 Base Sepolia #1267
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| absolutePrestate = "0x038dca684026d946d1d0ddb05d50685d1a0dab350b89d10b6705e83c41ec8755" # prestates."1.7.0-rc.5" https://github.com/ethereum-optimism/devnets/issues/123#issuecomment-3444735369 | ||
| expectedValidationErrors = "PDDG-VM-30,PLDG-VM-30" | ||
|
|
||
| # Soneium Testnet Minato (Permissioned) | ||
|
|
||
| [[opcmUpgrades]] | ||
| chainId = 1946 | ||
| absolutePrestate = "0x038dca684026d946d1d0ddb05d50685d1a0dab350b89d10b6705e83c41ec8755" # prestates."1.7.0-rc.5" https://github.com/ethereum-optimism/devnets/issues/123#issuecomment-3444735369 | ||
| expectedValidationErrors = "PDDG-VM-30,PDDG-130,PLDG-10" | ||
|
|
||
| # Ink Sepolia Testnet (Permissionless) | ||
|
|
||
| [[opcmUpgrades]] | ||
| chainId = 763373 | ||
| absolutePrestate = "0x038dca684026d946d1d0ddb05d50685d1a0dab350b89d10b6705e83c41ec8755" # prestates."1.7.0-rc.5" https://github.com/ethereum-optimism/devnets/issues/123#issuecomment-3444735369 | ||
| expectedValidationErrors = "PDDG-VM-30,PLDG-VM-30" |
There was a problem hiding this comment.
The identical absolutePrestate values across all three chains (OP Sepolia, Soneium Testnet Minato, and Ink Sepolia) present a potential safety risk. Each chain should have its own validated prestate hash specific to that network's state.
Issues identified:
- All chains use the same prestate hash:
0x038dca684026d946d1d0ddb05d50685d1a0dab350b89d10b6705e83c41ec8755 - The GitHub issue reference provides insufficient verification details
- No safeguards against copy-paste errors between chain configurations
Recommendations:
- Verify each chain has the correct individual prestate hash for its specific network state
- Add explicit validation steps in documentation to confirm prestate hashes match expected values per chain
- Implement checksums or additional verification mechanisms to prevent configuration errors between different chains
Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)
Is this helpful? React 👍 or 👎 to let us know.
| In this section, through a sequence of commands, we will successfully sign this task’s upgrade transaction from the 'base-nested' (`0x646132A1667ca7aD00d36616AFBA1A28116C770A`) safe. | ||
|
|
||
| ```bash | ||
| cd src/tasks/sep/029-U16a-opcm-upgrade-v410-base |
There was a problem hiding this comment.
The command references an incorrect directory path 'src/tasks/sep/029-U16a-opcm-upgrade-v410-base' instead of the current task directory 'src/tasks/sep/042-U17-sep-base'. This makes the task less robust as users will encounter errors when following the instructions. To fix this, update all directory references throughout the README to point to the correct task directory.
| cd src/tasks/sep/029-U16a-opcm-upgrade-v410-base | |
| cd src/tasks/sep/042-U17-sep-base |
Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| ## Objective | ||
|
|
||
| Upgrade Base Sepolia to U16a. More context on U16a can be found in the Optimism docs [here](https://docs.optimism.io/notices/upgrade-16a). |
There was a problem hiding this comment.
The PR description states this is a U17 upgrade, but the README incorrectly refers to upgrading "Base Sepolia to U16a" in the Objective section. This should be updated to "Upgrade Base Sepolia to U17" to maintain consistency with the PR title and description. The linked documentation should also be updated to point to U17 documentation rather than U16a.
| Upgrade Base Sepolia to U16a. More context on U16a can be found in the Optimism docs [here](https://docs.optimism.io/notices/upgrade-16a). | |
| Upgrade Base Sepolia to U17. More context on U17 can be found in the Optimism docs [here](https://docs.optimism.io/notices/upgrade-17). |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| # Base Operations Safe | ||
| 0x6AF0674791925f767060Dd52f7fB20984E8639d8 = [ | ||
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 10} # <--- THIS MUST BE CHANGED TO '11' FOR STEP 1A IN README.md FILE. |
There was a problem hiding this comment.
The hardcoded nonce value 10 creates a safety risk as operators must manually change it to 11 for Step 1a execution. This manual requirement increases the likelihood of execution errors or incorrect transaction ordering if the nonce update is forgotten. Consider either setting the correct nonce value directly in the configuration or implementing validation checks to verify the nonce has been properly updated before task execution.
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 10} # <--- THIS MUST BE CHANGED TO '11' FOR STEP 1A IN README.md FILE. | |
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 11} |
Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)
Is this helpful? React 👍 or 👎 to let us know.
1 participant
Jovian U17 upgrade task for Base Sepolia