Skip to content

Conversation

@Wazabie
Copy link
Contributor

@Wazabie Wazabie commented Oct 27, 2025

Jovian U17 upgrade task for Unichain Mainnet

@Wazabie Wazabie requested review from a team as code owners October 27, 2025 08:53
@Wazabie Wazabie requested a review from mslipper October 27, 2025 08:53
@Wazabie Wazabie self-assigned this Oct 27, 2025
Comment on lines +41 to +47
0x847B5c174615B1B7fDF770882256e2D3E95b9D92 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 46}
]

# Security Council
0xc2819DC788505Aac350142A7A707BF9D03E3Bd03 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 49}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent state override values between upgrade configurations

The state override values for the same addresses differ between the Arena-Z/Swell config and the Unichain config:

Address Arena-Z/Swell value Unichain value
Foundation Upgrade Safe (0x847B5c174615B1B7fDF770882256e2D3E95b9D92) 45 46
Security Council (0xc2819DC788505Aac350142A7A707BF9D03E3Bd03) 48 49

If these values represent sequential counters (like nonces), the discrepancy might indicate an incorrect assumption about execution order. Please verify whether these differences are intentional or if the values should be synchronized across both upgrade configurations.

Suggested change
0x847B5c174615B1B7fDF770882256e2D3E95b9D92 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 46}
]
# Security Council
0xc2819DC788505Aac350142A7A707BF9D03E3Bd03 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 49}
0x847B5c174615B1B7fDF770882256e2D3E95b9D92 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 45}
]
# Security Council
0xc2819DC788505Aac350142A7A707BF9D03E3Bd03 = [
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 48}

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@@ -0,0 +1 @@
TENDERLY_GAS=30000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing FORK_BLOCK_NUMBER configuration in the .env file reduces task robustness. Without a pinned block number, simulations may execute against different blockchain states, causing inconsistent results or unexpected behavior. Add FORK_BLOCK_NUMBER to ensure all simulations run against the same blockchain state, which is critical for upgrade tasks requiring contract state consistency.

Suggested change
TENDERLY_GAS=30000000
TENDERLY_GAS=30000000
FORK_BLOCK_NUMBER=18000000

Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant