Update EIP-4881: use valid Python typing for DepositTreeSnapshot.finalized #10818
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Collaborator
File
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the SSZ-style List[Hash32, DEPOSIT_CONTRACT_DEPTH] notation with valid Python typing List[Hash32] in both the EIP’s reference implementation and the Python reference code to align with Python’s typing.List which only accepts an element type parameter. The original form is SSZ syntax expressing a variable-length list with a maximum bound and is not understood by Python type checkers, leading to false-positive diagnostics and confusing IDE hints. The semantic constraint on maximum length remains enforced by the surrounding logic and tests that rely on DEPOSIT_CONTRACT_DEPTH; moving to List[Hash32] improves static analysis compatibility and readability without changing behavior.