Update EIP-8148: correct MAX_REQUESTS_PER_BLOCK in bytecode from 2 to 16#11331
Open
GarmashAlex wants to merge 1 commit intoethereum:masterfrom
Open
Update EIP-8148: correct MAX_REQUESTS_PER_BLOCK in bytecode from 2 to 16#11331GarmashAlex wants to merge 1 commit intoethereum:masterfrom
MAX_REQUESTS_PER_BLOCK in bytecode from 2 to 16#11331GarmashAlex wants to merge 1 commit intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
File
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bytecode contained
push1 0x02(2 requests) instead ofpush1 0x10(16 requests), contradicting the constantMAX_SET_SWEEP_THRESHOLD_REQUESTS_PER_BLOCK = 16defined in the specification table. This reduced throughput by 8x and caused queue congestion.Fixed two occurrences in the system call bytecode to use
0x10(16), matching EIP-7002's implementation and the documented constant.