Skip to content

Comments

Update EIP-8141: Fix some issues with EIP-8141#11344

Open
derekchiang wants to merge 3 commits intoethereum:masterfrom
derekchiang:eip-8141-fixes
Open

Update EIP-8141: Fix some issues with EIP-8141#11344
derekchiang wants to merge 3 commits intoethereum:masterfrom
derekchiang:eip-8141-fixes

Conversation

@derekchiang
Copy link

  • Remove several references to how APPROVE requires CALLER == frame.target which doesn't make sense since a typical VERIFY frame will have CALLER == ENTRY_POINT and frame.target == tx.sender, as seen from the examples. I believe the real intention is that APPROVE should be called by frame.target (or more precisely ADDRESS == frame.target), so I updated the language accordingly.

  • Restrict APPROVE to VERIFY frames. I believe this is the intention since APPROVE cannot be called from SENDER frames and it's not clear why it should ever be called from a DEFAULT frame since DEFAULT frames can modify state.

  • Clarify that frame reverts don't affect subsequent frames.

  • Fix some minor typos.

- Remove several references to how `APPROVE` requires
  `CALLER == frame.target` which doesn't make sense since a
  typical `VERIFY` frame will have `CALLER == ENTRY_POINT` and
  `frame.target == tx.sender`, as seen from the examples.  I
  believe the real intention is that `APPROVE` should be called by
  `frame.target` (or more precisely `ADDRESS == frame.target`),
  so I updated the language accordingly.

- Restrict `APPROVE` to `VERIFY` frames.  I believe this is the
  intention since `APPROVE` cannot be called from `SENDER` frames
  and it's not clear why it should ever be called from a `DEFAULT`
  frame since `DEFAULT` frames can modify state.

- Clarify that frame reverts don't affect subsequent frames.

- Some minor typos.
@derekchiang derekchiang requested a review from eth-bot as a code owner February 21, 2026 16:20
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Feb 21, 2026
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 21, 2026

File EIPS/eip-8141.md

Requires 1 more reviewers from @drortirosh, @fjl, @forshtat, @lightclient, @shahafn, @vbuterin, @yoavw

@eth-bot eth-bot added the a-review Waiting on author to review label Feb 21, 2026
@eth-bot eth-bot changed the title Fix some issues with EIP-8141 Update EIP-8141: Fix some issues with EIP-8141 Feb 21, 2026
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Definitely a mistake by me when I was refactoring approve. I definitely meant it to be ADDRESS == frame.target like you wrote.

I would like to remove the restriction on calling approve only in "verify" frames though. Builders may want to have stateful frames approve a transaction - those just wouldn't propagate through the public txpool.

@derekchiang
Copy link
Author

Thanks for this! Definitely a mistake by me when I was refactoring approve. I definitely meant it to be ADDRESS == frame.target like you wrote.

I would like to remove the restriction on calling approve only in "verify" frames though. Builders may want to have stateful frames approve a transaction - those just wouldn't propagate through the public txpool.

Understood -- removed the restriction just now.

@nlordell
Copy link

nlordell commented Feb 23, 2026

While you're here - was the TXPARAM meant to jump from 0x09 to 0x10 and skip 0x0[a-f], or was it just a decimal/hex typo (was mentioned by someone else in a Telegram group)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants