Skip to content

Update EIP-1052: fix eip-1052.md #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sky-coderay
Copy link

keccack256 - keccak256
no more typos found in docs.Thanks

@sky-coderay sky-coderay requested a review from eth-bot as a code owner December 22, 2024 20:30
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Dec 22, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 22, 2024

File EIPS/eip-1052.md

Requires 2 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Dec 22, 2024
@eth-bot eth-bot changed the title fix eip-1052.md Update EIP-1052: fix eip-1052.md Dec 22, 2024
Copy link

The commit 692c252 (as a parent of a59462d) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 22, 2024
@Marchhill
Copy link
Contributor

Ensure all checks are passing

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Dec 23, 2024
@sky-coderay
Copy link
Author

@Marchhill Done, thank you! I'm glad if I was helpful.

  • Added missing fields in the preamble (e.g., description, GitHub usernames in author).
  • Shortened long lines and removed trailing spaces to pass MarkdownLint.
  • Fixed the order of required sections (added Security Considerations after Reference Implementation, and added Copyright).
  • The second level (##), as required by the validator.

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many changes here for a final proposal. Please keep your edits minimal, and only fix one specific issue per PR. In this case, you're reformatting line width, which makes it difficult to review.

@@ -1,7 +1,8 @@
---
eip: 1052
title: EXTCODEHASH opcode
author: Nick Johnson <[email protected]>, Paweł Bylica <[email protected]>
description: Returns the keccak256 hash of a contract's code
author: Nick Johnson (@arachnid), Paweł Bylica (@chfast)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a final proposal, so it isn't important to update the author line. No one has automatic merge permissions anyway.

Suggested change
author: Nick Johnson (@arachnid), Paweł Bylica (@chfast)
author: Nick Johnson <arachnid@notdot.net>, Paweł Bylica <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants