Skip to content

Update EIP-7594: Polish EIP, expand rationale #9588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Apr 2, 2025

  • move EIP category to Core
  • minor edits on language, more explanation or links to helper code
  • polish missing EIP sections
  • add security rationale, referencing this document from @fradamt : https://hackmd.io/@fradamt/SyutzooCkg

@ralexstokes ralexstokes requested a review from eth-bot as a code owner April 2, 2025 21:47
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Apr 2, 2025
@ralexstokes ralexstokes closed this Apr 2, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 2, 2025

File EIPS/eip-7594.md

Requires 1 more reviewers from @dankrad, @djrtwo, @fradamt, @hwwhww

@ralexstokes ralexstokes reopened this Apr 2, 2025
@ralexstokes ralexstokes marked this pull request as draft April 2, 2025 21:47
@eth-bot eth-bot added the a-review Waiting on author to review label Apr 2, 2025
@eth-bot eth-bot changed the title Polish EIP, expand rationale Update EIP-7594: Polish EIP, expand rationale Apr 2, 2025
@ralexstokes ralexstokes force-pushed the eip7594/add-rationale branch 4 times, most recently from acba5cc to 691064a Compare April 2, 2025 21:55
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 2, 2025
@ralexstokes ralexstokes force-pushed the eip7594/add-rationale branch from c78b62a to 9aa962b Compare May 1, 2025 22:19
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 1, 2025
@ralexstokes ralexstokes force-pushed the eip7594/add-rationale branch from 6abeb8f to e26bea7 Compare May 1, 2025 22:58
@ralexstokes
Copy link
Member Author

still reviewing the security section with @fradamt and @MarcoPolo

@ralexstokes ralexstokes marked this pull request as ready for review May 1, 2025 23:00
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 1, 2025
Copy link

github-actions bot commented May 1, 2025

The commit e26bea7 (as a parent of 9ed881c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants