-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add EIP: Algorithmic Transaction Wrapper #9633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add EIP: Algorithmic Transaction Wrapper #9633
Conversation
File
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea to already think about how we can plugin new signature schemes but I am not sure if this is the "best" way to do it. I think a more cleaner approach would be to already have this feature in the transactions themselves (so the signing is a "module" and can either take the form of secp256k1 or something new). But, this is obviously not possible so we need another mechanism to swap it out for something else and this is already a good start 😄 👍
I completely agree, it would be nicer to have signing modules embedded in transactions, but as you said, it would break backwards compatibility in almost every way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly penalty calculation adds gas before transaction processing, but how do you clarify how this interacts with user-specified gas limits and transaction fee structures?
Co-authored-by: Sam Wilson <[email protected]>
The commit e3d3a5c (as a parent of 5d39406) contains errors. |
This EIP introduces a new wrapper type transaction to allow for alternative signature algorithms to sign off on an ethereum transactions.