-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add EIP: Ethereum Intent URI (EIURI) #9644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
File
|
The commit 101e512 (as a parent of 11e342d) contains errors. |
hi @SamWilsn @g11tech @lightclient ! The Continuous Integration is failing because the HTMLProofer job was cancelled be cause there is a an error in ubuntu version. Still throwing same error message:
https://github.com/ethereum/EIPs/actions/runs/14471530424/job/40586478241?pr=9644 Could you take a look of this ? Regards! |
Please rebase against master as the issue with the HTML proofer has been fixed. |
…or current account and zero address. This allows wallets to substitute the user's active address and maintain consistency for RPC calls without a target address.
…ects and arrays in URI parameters, improving clarity and usability for complex data structures.
…ng for the request structure and emphasizing the `CURRENT_ACCOUNT` placeholder. This enhances readability and maintains consistency in documentation.
title: Ethereum Intent URI (EIURI) | ||
description: A Universal action URI format for Ethereum (represent and trigger Ethereum RPC requests) | ||
author: Frani (@frani) | ||
discussions-to: https://ethereum-magicians.org/t/eip-7924-ethereum-intent-uri-ei-uri-a-universal-action-uri-format-for-ethereum/23554 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eip number and eip number in link doesn't match,
|
||
## Test Cases | ||
|
||
TBD – Will include example URIs and expected behavior in compatible wallets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a html <--TODO--> tag so that bot can flag this if you try to move beyond draft and still not addressed this TBD
|
||
## Reference Implementation | ||
|
||
A reference implementation could be built as a lightweight URI parser in JavaScript that extracts and maps the URL to a `window.ethereum.request(...)` call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be build
is not correct for this section, either add reference implementation link/details or mark it as <--TODO-->
--- | ||
eip: 7933 | ||
title: Ethereum Intent URI (EIURI) | ||
description: A Universal action URI format for Ethereum (represent and trigger Ethereum RPC requests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: A Universal action URI format for Ethereum (represent and trigger Ethereum RPC requests) | |
description: A Universal action URI format for Ethereum (represent and trigger Ethereum JSON-RPC requests) |
{ | ||
"chainId": "0x1", | ||
"chainName": "Ethereum Mainnet", | ||
"rpcUrls": ["https://mainnet.infura.io/v3/..."], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using real services, this URL can be example.com.
"symbol": "ETH", | ||
"decimals": 18 | ||
}, | ||
"blockExplorerUrls": ["https://etherscan.io"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using real services, this URL can be example.com.
Can be represented as: | ||
|
||
` | ||
ethereum:wallet_addEthereumChain-0x0000000000000000000000000000000000000000?chainId=0x1&chainName=Ethereum%20Mainnet&rpcUrls[0]=https%3A%2F%2Fmainnet.infura.io%2Fv3%2F...&iconUrls[0]=https%3A%2F%2Fexample.com%2Ficon.png&nativeCurrency[name]=Ether&nativeCurrency[symbol]=ETH&nativeCurrency[decimals]=18&blockExplorerUrls[0]=https%3A%2F%2Fetherscan.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using real services and instead use example.com domains.
**wallet_addEthereumChain** | ||
|
||
` | ||
ethereum:wallet_addEthereumChain-0x0000000000000000000000000000000000000000?chainId=0x64&chainName=Gnosis&rpcUrls[0]=https%3A%2F%2Frpc.gnosischain.com&iconUrls[0]=https%3A%2F%2Fxdaichain.com%2Ffake%2Fexample%2Furl%2Fxdai.svg%2Chttps%3A%2F%2Fxdaichain.com%2Ffake%2Fexample%2Furl%2Fxdai.png&nativeCurrency[name]=xDAI&nativeCurrency[symbol]=xDAI&nativeCurrency[decimals]=18&blockExplorerUrls[0]=https%3A%2F%2Fgnosisscan.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using real services and products names in the examples.
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: