Update ERC-7943: Fix examples #1340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
File
|
xaler5
reviewed
Nov 7, 2025
| /// @dev Can only be called by accounts holding the `WHITELIST_ROLE`. | ||
| /// Emits a {Whitelisted} event. | ||
| /// @param account The address whose whitelist status is to be changed. | ||
| /// @param account The address whose whitelist status is to be changed. Must not be the zero address. |
Contributor
There was a problem hiding this comment.
Since it's not enforced, I'd remove this "Must" from here.
xaler5
reviewed
Nov 7, 2025
| /// @param account The address whose whitelist status is to be changed. Must not be the zero address. | ||
| /// @param status The new whitelist status (true = whitelisted, false = not whitelisted). | ||
| function changeWhitelist(address account, bool status) external onlyRole(WHITELIST_ROLE) { | ||
| function changeWhitelist(address account, bool status) external virtual onlyRole(WHITELIST_ROLE) { |
Contributor
There was a problem hiding this comment.
This is not virtual in uRWA20 and uRWA721, is it needed ?
xaler5
reviewed
Nov 7, 2025
|
|
||
| /// @inheritdoc IERC7943MultiToken | ||
| function getFrozenTokens(address account, uint256 tokenId) external view returns (uint256 amount) { | ||
| function getFrozenTokens(address account, uint256 tokenId) public view virtual override returns (uint256 amount) { |
Contributor
There was a problem hiding this comment.
Now that you made me think that this is public, instead of using _frozenTokens[account] we could be using getFrozenTokens directly, and improve readability. Wdyt ?
xaler5
reviewed
Nov 7, 2025
| function forcedTransfer(address from, address to, uint256 tokenId, uint256 amount) public onlyRole(FORCE_TRANSFER_ROLE) returns(bool result) { | ||
| function forcedTransfer(address from, address to, uint256 tokenId, uint256 amount) public virtual override onlyRole(FORCE_TRANSFER_ROLE) returns(bool result) { | ||
| require(to != address(0), ERC1155InvalidReceiver(address(0))); | ||
| require(from != address(0), ERC1155InvalidSender(address(0))); |
Contributor
There was a problem hiding this comment.
Should we add this check also in uRWA721 to make it consistent all across the three cases ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: