-
Notifications
You must be signed in to change notification settings - Fork 847
Update ERC-5564: fix typos and empty lines #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I submitted this fix 16 hours before #1437 (see timestamps). While I understand my PR has formatting issues due to auto-formatting, the proper approach would have been to ask me to fix the formatting rather than submitting a duplicate PR. I found this typo independently and submitted it first. Taking someone else's find and resubmitting it with minor changes isn't good practice. If formatting was the only issue, I'm happy to fix it right now. Or I don't understand what's the point of contributing to open source projects if anyone can present it as their own simply because they're part of the inner circle. And that's just with typos - how can I make serious contributions after that? I'm not trying to create drama - I'm genuinely trying to understand the process here. Should I close my PR every time someone with contributor status submits the same fix later? |
|
I don't care about you airdrop farming, tbh. Do something meaningful with your time, noone cares about trailing spaces and that formatting stuff you fixed. |
|
I don't understand the airdrop comment. I found this typo while studying documentation and submitted a fix. Instead of helping me fix the formatting issues, you copied my finding and submitted it as your own PR. Now you're accusing me of farming? Your 20,000+ contributions from typo fixes say more about who's actually farming here. Next time, just comment on the original PR with suggestions instead of duplicating someone else's work. |
|
@nerolation Tech community exists and people support each other when something this-like occurs. Fake thumb-downs, take off your rose-tinted glasses. Stroke your ego with stolen contributions raising number. I wish there were more decent human-beings in this world. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Even though this is a CC0 licensed repo, It would be nice to recognize the original submitter’s effort by either pushing to his branch, rebasing the original patch or requesting for changes, all of which are technically possible. Your responses are clearly breaking the Ethereum CoC and I urge you to retract some of those unwelcoming statements and threats. We need to maintain a healthy, respectful and welcoming project culture around here. |
|
I am a Cointelegraph journalist. Also feel free to reach out to me at [email protected], if you prefer. |
No description provided.