Skip to content

Add ERC: Universal On-Chain Metadata Parser Interface #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ZeroKPunk
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Dec 6, 2024

File ERCS/erc-7835.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@@ -0,0 +1,192 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7835

Assigning next sequential EIP/ERC/RIP number.
Numbers are assigned by editors & associates.

Please also update the filename.

title: wallet_transmitCrossChainIntents Method
description: Standard Cross-Chain Intent Parsing Method For EVM Wallet
author: ZeroKPunk (@ZeroKPunk), 0xbbPizza (0xbbPizza)
discussions-to: <URL>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a discussions topic in Eth Magicians with a link to this PR: https://ethereum-magicians.org/c/ercs/57

ZeroKPunk and others added 2 commits December 11, 2024 11:31
… Ethereum

- Completely redefined the purpose of the ERC from a cross-chain wallet RPC to a metadata abstraction parser for Ethereum.
- Broadened the scope to enable wider applicability across diverse Ethereum use cases.
- Focused on providing a standardized interface for parsing Ethereum network metadata.
- Removed cross-chain wallet RPC specifics to align with the new goal of flexibility and broader adoption.
@eip-review-bot eip-review-bot changed the title Add ERC: wallet_transmitCrossChainIntents Method Add ERC: Standard Metadata Abstract Parsing Interface For EVM Wallet Dec 11, 2024
@github-actions github-actions bot removed the w-ci label Dec 11, 2024
@github-actions github-actions bot added the w-ci label Dec 11, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Standard Metadata Abstract Parsing Interface For EVM Wallet Add ERC: Unified Metadata Abstract Parsing Interface For EVM Wallet Dec 11, 2024
@github-actions github-actions bot added w-ci and removed w-ci labels Dec 11, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Unified Metadata Abstract Parsing Interface For EVM Wallet Add ERC: Universal On-Chain Metadata Parser Interface Dec 11, 2024
@github-actions github-actions bot removed the w-ci label Dec 11, 2024
Copy link

The commit 4d80df3 (as a parent of dd694df) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Dec 11, 2024
---
eip: 7835
title: Universal On-Chain Metadata Parser Interface
description: A universal interface for parsing wallet-accessed metadata, enhancing security, usability, and data readability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description contains only either a restatement of your title ("A universal interface for parsing...metadata") or fluff ("enhancing security, usability, and data readability".)

Try to include more information in your description than was already introduced in your title.

For example, you could try to answer questions like:

  • What is metadata?
  • How is it universal?
  • How is it parsed on chain, and why would you want it there?


## Abstract

This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to Wallets. The standard consists of two core components:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata (MetaData)

Is "MetaData" different from "metadata"?


## Abstract

This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to Wallets. The standard consists of two core components:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to Wallets. The standard consists of two core components:
This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to wallets. The standard consists of two core components:


This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to Wallets. The standard consists of two core components:

- **1.Wallet-level parser interface:** wallet_metaDataAbstractParser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline code should be enclosed in backticks (`) throughout the document. Also, just use a regular markdown ordered list.

Suggested change
- **1.Wallet-level parser interface:** wallet_metaDataAbstractParser
1. Wallet-level parser interface:** `wallet_metaDataAbstractParser`

This proposal defines a standardized interface for parsing on-chain metadata (MetaData) relevant to Wallets. The standard consists of two core components:

- **1.Wallet-level parser interface:** wallet_metaDataAbstractParser
A universal entry point that Wallets can use to request metadata parsing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet isn't a proper noun.

Suggested change
A universal entry point that Wallets can use to request metadata parsing.
A universal entry point that wallets can use to request metadata parsing.


### 2. Smart Contract-Level Parsing Logic: parserHandler and parserData

`parserHandler` is a smart contract deployed on-chain that implements the actual parsing logic. It receives parameters from Wallets and returns parsed, human-readable metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`parserHandler` is a smart contract deployed on-chain that implements the actual parsing logic. It receives parameters from Wallets and returns parsed, human-readable metadata.
`parserHandler` is the address of a smart contract deployed on-chain that implements the actual parsing logic. It receives parameters from Wallets and returns parsed, human-readable metadata.


## Rationale

### **1. Generalization:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use normal headings. You don't need to do manual numbering.


## Security Considerations

### Parsing Logic Security:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Parsing Logic Security:
### Parsing Logic Security


- Parsing contracts should be audited to prevent potential vulnerabilities or malicious behavior.

### User Privacy:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### User Privacy:
### User Privacy


- Wallets must ensure that user data is handled securely and not leaked during parsing.

### Trust Minimization:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Trust Minimization:
### Trust Minimization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants