-
Notifications
You must be signed in to change notification settings - Fork 630
Update ERC-7786: Extend ERC 7786 to support PULL communication mode #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
philippecamacho
wants to merge
24
commits into
ethereum:master
Choose a base branch
from
philippecamacho:philippe/erc7786-pull-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
80f16b9
Add receiveMessage function.
philippecamacho ac48377
typo
philippecamacho 51b2b89
Mention of attributes for sendMessage.
philippecamacho 42cca85
messageId should be a bytes32
philippecamacho 95b2fe5
Add / fix sequence diagrams.
philippecamacho b58b3a6
There are two workflows now.
philippecamacho ac208fb
Update Motivation and Rationale sections
philippecamacho 6ad57be
Fix typos
philippecamacho e592c42
Make the type messageId bytes instead of bytes32.
philippecamacho 537f154
Fix send-receive diagram
philippecamacho a977729
Remove prettifier changes
philippecamacho 15c1f1b
Attributes are optional but some can be set by default.
philippecamacho e979ea7
messageKey parameter for receiveMessage
philippecamacho a7c919e
messageKey -> messageId
philippecamacho b4724fb
Make messageId a field of the message.
philippecamacho 1f9139b
Remove mention of pushBased attribute.
philippecamacho 63c1aae
Improve wording
philippecamacho 018174a
Add missing calldata for messageId
philippecamacho 51390cb
pushBased attribute specification.
philippecamacho 48d93ec
The Gateway does not have to support the pushBased attribute.
philippecamacho b7e8f52
Fix typo
philippecamacho 347fa59
Update ERCS/erc-7786.md
philippecamacho 39159f7
Remove mention of PUSH and PULL communication modes in the Motivation…
philippecamacho b566adb
Add comment for parameter of function.
philippecamacho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
sequenceDiagram | ||
box Source chain | ||
participant Sender | ||
participant SourceGateway | ||
end | ||
box Destination chain | ||
participant DestinationGateway | ||
participant Receiver | ||
end | ||
Sender->>SourceGateway: sendMessage(...) | ||
SourceGateway-->>DestinationGateway: [underlying protocol] | ||
Receiver->>Receiver: f(...) starts execution | ||
Receiver->>DestinationGateway: receiveMessage(...) | ||
Receiver->>Receiver: f(...) ends execution | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have concerns about using push and pull in this way, based on our conversations in the working group. I think these terms are too broad, and mean different things to different people, and so adding this here could lead to confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, also because PUSH/PULL communication modes are not defined in this section. The sentence was removed in 39159f7.