Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation and Improve Clarity in Smart Contracts #925

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maximevtush
Copy link

This pull request addresses several documentation issues across multiple smart contract files. The changes include:

  1. ERC6464 Interface: Updated the notice for the revokeAllExplicitApprovals function to clarify that it revokes all explicit approvals granted for the specified token.
  2. Locking Contract: Improved the explanation regarding the locking mechanism, specifying that the token is locked with two different addresses (buyer/seller).
  3. LibAccessLayers: Minor adjustments to comments for better readability and understanding.

These changes aim to enhance the clarity and accuracy of the documentation, making it easier for developers to understand the functionality of the contracts.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 26, 2025

File ERCS/erc-6464.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

File ERCS/erc-7573.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

File ERCS/erc-7746.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

@@ -6,7 +6,7 @@ library LibAccessLayers {
bytes32 constant ACCESS_LAYERS_STORAGE_POSITION = keccak256("lib.access.layer.storage");

struct LayerStruct {
address layerAddess;
address layerAddress;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peersky I assume you're okay with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for fixing!

Copy link
Contributor

@peersky peersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC7746 changes - LGTM!

@@ -6,7 +6,7 @@ library LibAccessLayers {
bytes32 constant ACCESS_LAYERS_STORAGE_POSITION = keccak256("lib.access.layer.storage");

struct LayerStruct {
address layerAddess;
address layerAddress;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for fixing!

@maximevtush
Copy link
Author

@peersky ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants