-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove SSZ unions #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove SSZ unions #3906
Conversation
…iew' imported but unused
|
unions were used in very old versions of sharding specs, and its possible we could use them in future iterations of the spec instead of deleting them, we could add a note that they are not part of a "core" or "minimum required functionality" SSZ implementation |
|
another data point: Portal uses unions in their networking specs here: https://github.com/ethereum/portal-network-specs/blob/master/portal-wire-protocol.md |
|
I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake |
|
Yeah, I've been monitoring the relevant conditions for this. The last real user was Portal, which is why I didn't take further action on it. But conditions around Portal changed.I I'm not sure I can reopen, but it should be reopened. |
|
Has this been discussed in an EIP? If we want to modify the SSZ standard, I guess the community should give feedback through the EIP process? |
|
We (LH) use union internally for data we store on disk. Having an SSZ type that corresponds to a tagged enum with arbitrary variants is very useful for us. If deleted from the spec we will likely maintain our implementation as a non-standard extension. |
SSZ unions are not used and have never been used in any version of deployed consensus-layer Ethereum. Align spec with this.